Conversation
Introduced Field and FieldList classes with mapped DXF codes and supporting enums. Updated DxfClassCollection and DxfObjectsSectionReader for FIELD/FIELDLIST registration and parsing. Added CadFieldTemplate for FIELD object handling. Introduced CadValue (replacing obsolete TableEntity.CellValue). These changes improve DXF compatibility and object coverage.
Introduce CadValueType and CadValueUnitType enums to replace legacy value/unit types, improving clarity and extensibility. Update CadValue and related readers to use these enums. Refactor proxy object handling in DXF reader to use a new CadProxyObjectTemplate, which manages handle entries. Enhance Field class with explicit DxfCodeValue attributes for format strings. Add support for additional DXF codes in proxy object reading logic.
Introduce BlockReferenceObjectContextData for block refs, including insertion point, rotation, and scale factors with validation. Expand DxfFileToken constants and update DxfObjectsSectionReader to handle new context data. Refactor AnnotScaleObjectContextData and ObjectContextData for clarity and improved documentation. Enhances DXF annotation scaling and context parsing.
Refactored object context data reading for annotation scales and multi-leader objects in both DWG and DXF importers. In DWG, added explicit reading of the scale handle. In DXF, switched to DxfClassMap for MultiLeaderObjectContextData and improved property assignment logic. Commented out conflicting DxfCodeValue attribute for annotation scale due to code 340 overlap, with a TODO for future resolution. These changes enhance mapping accuracy and highlight a known DXF code conflict.
Added parsing for ACDB_MTEXTATTRIBUTEOBJECTCONTEXTDATA_CLASS objects in the DXF reader. Introduced a new constant and class for MTextAttributeObjectContextData, mapping relevant DXF codes to properties. This enhances support for annotative MText attributes in DXF files.
Refactored DwgObjectReader to add methods for reading annotation scale, block reference, and MText attribute object context data. Updated switch statement to handle new DxfFileToken cases. Simplified readObjectContextData to only read version and default flag, removing unused fields. Cleaned up formatting and removed obsolete methods.
Refactored Arc constructor to correctly assign StartAngle and EndAngle based on input points, and removed the unused IsCounterClockWise property. Simplified Insert transformation logic for Arc entities by eliminating direction checks. Added a unit test for Arc initialization. Updated project version to 3.4.8 and performed minor cleanup in LocalSampleTests.cs.
Recognize Field, FieldList, BlockReferenceObjectContextData, and MTextAttributeObjectContextData in both DWG and DXF writers. Mark these as supported in DWG, and notify as not implemented in DXF. Comment out annotation scale reading for MTextAttributeObjectContextData in DwgObjectReader. Remove redundant return in test code.
Reorganized and cleaned up the DxfFileToken class by removing region and XML comments, and regrouping related constants for better readability. Restored several table, object, and reactor constants to improve logical structure. No functional changes were made.
Added AcDbMTextAttributeObjectContextData and AcDbBlkRefObjectContextData to DxfClassCollection with proper registration. Introduced corresponding subclass marker constants in DxfSubclassMarker.cs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation for:
Implementations are only for the readers the writers will ignore this objects.