Skip to content

Conversation

@robertomonteromiguel
Copy link
Collaborator

…onent mapping

Motivation

Docker SSI extracted component name from "datadog-apm-library-js" as "js", but manifest
system expects "nodejs" to match nodejs.yml file. This prevented test skip/xfail markers
from being applied to Node.js Docker SSI tests.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

utils/_context/_scenarios/docker_ssi.py                                 @DataDog/system-tests-core

@datadog-official
Copy link

datadog-official bot commented Jan 29, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

tests.appsec.api_security.test_endpoint_discovery.Test_Endpoint_Discovery.test_single_is_first[flask-poc] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: Expected one is_first=true payload, found 2
assert 2 == 1

self = <tests.appsec.api_security.test_endpoint_discovery.Test_Endpoint_Discovery object at 0x7faf186d71d0>

    def test_single_is_first(self):
        """Verify that the is_first flag appears exactly once in telemetry.
    
        Mandatory for the feature.
        """
...
tests.appsec.api_security.test_schemas.Test_Scanners.test_request_method[uds-spring-boot] from system_tests_suite (Datadog) (Fix with Cursor)
assert None

self = <tests.appsec.api_security.test_schemas.Test_Scanners object at 0x7f2f84355e80>

    def test_request_method(self):
        """Can provide request header schema"""
        schema_cookies = get_schema(self.request, "req.cookies")
        schema_headers = get_schema(self.request, "req.headers")
        assert self.request.status_code == 200
>       assert schema_cookies
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 789b650 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review January 29, 2026 13:03
@robertomonteromiguel robertomonteromiguel requested a review from a team as a code owner January 29, 2026 13:03
@robertomonteromiguel robertomonteromiguel merged commit aff10f1 into main Jan 29, 2026
1978 of 1981 checks passed
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/fix_docker_ssi_library_name branch January 29, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants