Skip to content

Always record force keep decisions for future distributed trace propagation #10308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcculls merged 1 commit into from
Jan 7, 2026
Merged

Always record force keep decisions for future distributed trace propagation #10308

mcculls merged 1 commit into from
Jan 7, 2026

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Jan 7, 2026 •
edited by atlassian bot
Loading

Motivation

Fixes an issue uncovered by DataDog/system-tests#5617

While manually overriding the sampling decision was correctly updating the sampling priority in the local root span, it wasn't overriding the decision maker tag for future distributed trace propagation if a sampling priority had already been propagated.

Additional Notes

This change in behaviour should be called out in the release notes.

Contributor Checklist

Jira ticket: APMAPI-1721

@mcculls mcculls requested review from a team as code owners January 7, 2026 19:00
@mcculls mcculls added the type: bug Bug report and fix label Jan 7, 2026
@mcculls mcculls requested review from mtoffl01 and removed request for a team January 7, 2026 19:00
@mcculls mcculls added tag: breaking change Breaking changes comp: context propagation Trace context propagation labels Jan 7, 2026
@mcculls mcculls requested a review from ygree January 7, 2026 19:00
ygree
ygree approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix!

@pr-commenter
Copy link

pr-commenter bot commented Jan 7, 2026

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/propagate-force-keep-decision
git_commit_date 1767796928 1767812358
git_commit_sha 7f33e50 8439624
release_version 1.59.0-SNAPSHOT~7f33e50a42 1.59.0-SNAPSHOT~84396240be
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1767814263 1767814263
ci_job_id 1334055474 1334055474
ci_pipeline_id 89524341 89524341
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-s39g8o6o 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-s39g8o6o 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~84396240be, baseline=1.59.0-SNAPSHOT~7f33e50a42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089074
Total [baseline] (8.765 s) : 0, 8764811
Agent [candidate] (1.083 s) : 0, 1082943
Total [candidate] (8.725 s) : 0, 8725131
section iast
Agent [baseline] (1.239 s) : 0, 1238596
Total [baseline] (9.333 s) : 0, 9332938
Agent [candidate] (1.232 s) : 0, 1231965
Total [candidate] (9.344 s) : 0, 9344026
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.239 s 149.522 ms (13.7%)
Total tracing 8.765 s -
Total iast 9.333 s 568.127 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent iast 1.232 s 149.022 ms (13.8%)
Total tracing 8.725 s -
Total iast 9.344 s 618.895 ms (7.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~84396240be, baseline=1.59.0-SNAPSHOT~7f33e50a42

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (654.572 ms) : 0, 654572
BytebuddyAgent [candidate] (650.584 ms) : 0, 650584
GlobalTracer [baseline] (283.916 ms) : 0, 283916
GlobalTracer [candidate] (282.483 ms) : 0, 282483
AppSec [baseline] (32.683 ms) : 0, 32683
AppSec [candidate] (32.492 ms) : 0, 32492
Debugger [baseline] (67.511 ms) : 0, 67511
Debugger [candidate] (67.484 ms) : 0, 67484
Remote Config [baseline] (637.251 µs) : 0, 637
Remote Config [candidate] (627.504 µs) : 0, 628
Telemetry [baseline] (9.057 ms) : 0, 9057
Telemetry [candidate] (8.889 ms) : 0, 8889
Flare Poller [baseline] (3.783 ms) : 0, 3783
Flare Poller [candidate] (3.681 ms) : 0, 3681
section iast
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (803.207 ms) : 0, 803207
BytebuddyAgent [candidate] (797.624 ms) : 0, 797624
GlobalTracer [baseline] (258.131 ms) : 0, 258131
GlobalTracer [candidate] (257.859 ms) : 0, 257859
AppSec [baseline] (33.073 ms) : 0, 33073
AppSec [candidate] (33.655 ms) : 0, 33655
Debugger [baseline] (67.053 ms) : 0, 67053
Debugger [candidate] (65.938 ms) : 0, 65938
Remote Config [baseline] (597.544 µs) : 0, 598
Remote Config [candidate] (613.08 µs) : 0, 613
Telemetry [baseline] (8.529 ms) : 0, 8529
Telemetry [candidate] (8.471 ms) : 0, 8471
Flare Poller [baseline] (3.647 ms) : 0, 3647
Flare Poller [candidate] (3.596 ms) : 0, 3596
IAST [baseline] (27.308 ms) : 0, 27308
IAST [candidate] (27.434 ms) : 0, 27434
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~84396240be, baseline=1.59.0-SNAPSHOT~7f33e50a42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092063
Total [baseline] (10.789 s) : 0, 10789241
Agent [candidate] (1.085 s) : 0, 1085197
Total [candidate] (10.84 s) : 0, 10840220
section appsec
Agent [baseline] (1.265 s) : 0, 1264895
Total [baseline] (10.855 s) : 0, 10854589
Agent [candidate] (1.269 s) : 0, 1269348
Total [candidate] (10.903 s) : 0, 10903282
section iast
Agent [baseline] (1.224 s) : 0, 1224123
Total [baseline] (11.184 s) : 0, 11183920
Agent [candidate] (1.224 s) : 0, 1224457
Total [candidate] (11.313 s) : 0, 11313437
section profiling
Agent [baseline] (1.212 s) : 0, 1212319
Total [baseline] (11.013 s) : 0, 11012608
Agent [candidate] (1.203 s) : 0, 1203462
Total [candidate] (10.933 s) : 0, 10933083
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.265 s 172.832 ms (15.8%)
Agent iast 1.224 s 132.06 ms (12.1%)
Agent profiling 1.212 s 120.256 ms (11.0%)
Total tracing 10.789 s -
Total appsec 10.855 s 65.348 ms (0.6%)
Total iast 11.184 s 394.679 ms (3.7%)
Total profiling 11.013 s 223.367 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent appsec 1.269 s 184.151 ms (17.0%)
Agent iast 1.224 s 139.26 ms (12.8%)
Agent profiling 1.203 s 118.265 ms (10.9%)
Total tracing 10.84 s -
Total appsec 10.903 s 63.062 ms (0.6%)
Total iast 11.313 s 473.217 ms (4.4%)
Total profiling 10.933 s 92.863 ms (0.9%) 
gantt
    title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~84396240be, baseline=1.59.0-SNAPSHOT~7f33e50a42

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (656.107 ms) : 0, 656107
BytebuddyAgent [candidate] (650.99 ms) : 0, 650990
GlobalTracer [baseline] (284.379 ms) : 0, 284379
GlobalTracer [candidate] (282.876 ms) : 0, 282876
AppSec [baseline] (32.798 ms) : 0, 32798
AppSec [candidate] (32.678 ms) : 0, 32678
Debugger [baseline] (68.404 ms) : 0, 68404
Debugger [candidate] (68.679 ms) : 0, 68679
Remote Config [baseline] (618.449 µs) : 0, 618
Remote Config [candidate] (628.012 µs) : 0, 628
Telemetry [baseline] (9.033 ms) : 0, 9033
Telemetry [candidate] (8.958 ms) : 0, 8958
Flare Poller [baseline] (3.771 ms) : 0, 3771
Flare Poller [candidate] (3.675 ms) : 0, 3675
section appsec
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (690.301 ms) : 0, 690301
BytebuddyAgent [candidate] (691.726 ms) : 0, 691726
GlobalTracer [baseline] (258.297 ms) : 0, 258297
GlobalTracer [candidate] (259.802 ms) : 0, 259802
AppSec [baseline] (174.398 ms) : 0, 174398
AppSec [candidate] (174.631 ms) : 0, 174631
Debugger [baseline] (66.703 ms) : 0, 66703
Debugger [candidate] (67.853 ms) : 0, 67853
Remote Config [baseline] (793.872 µs) : 0, 794
Remote Config [candidate] (750.373 µs) : 0, 750
Telemetry [baseline] (9.443 ms) : 0, 9443
Telemetry [candidate] (9.437 ms) : 0, 9437
Flare Poller [baseline] (3.748 ms) : 0, 3748
Flare Poller [candidate] (3.714 ms) : 0, 3714
IAST [baseline] (24.627 ms) : 0, 24627
IAST [candidate] (24.8 ms) : 0, 24800
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (791.562 ms) : 0, 791562
BytebuddyAgent [candidate] (791.086 ms) : 0, 791086
GlobalTracer [baseline] (256.108 ms) : 0, 256108
GlobalTracer [candidate] (256.455 ms) : 0, 256455
AppSec [baseline] (34.598 ms) : 0, 34598
AppSec [candidate] (34.488 ms) : 0, 34488
Debugger [baseline] (65.559 ms) : 0, 65559
Debugger [candidate] (66.015 ms) : 0, 66015
Remote Config [baseline] (575.273 µs) : 0, 575
Remote Config [candidate] (581.451 µs) : 0, 581
Telemetry [baseline] (8.455 ms) : 0, 8455
Telemetry [candidate] (8.527 ms) : 0, 8527
Flare Poller [baseline] (3.539 ms) : 0, 3539
Flare Poller [candidate] (3.643 ms) : 0, 3643
IAST [baseline] (26.886 ms) : 0, 26886
IAST [candidate] (26.98 ms) : 0, 26980
section profiling
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (706.943 ms) : 0, 706943
BytebuddyAgent [candidate] (702.003 ms) : 0, 702003
GlobalTracer [baseline] (221.687 ms) : 0, 221687
GlobalTracer [candidate] (220.267 ms) : 0, 220267
AppSec [baseline] (32.426 ms) : 0, 32426
AppSec [candidate] (31.981 ms) : 0, 31981
Debugger [baseline] (68.628 ms) : 0, 68628
Debugger [candidate] (67.922 ms) : 0, 67922
Remote Config [baseline] (619.196 µs) : 0, 619
Remote Config [candidate] (644.265 µs) : 0, 644
Telemetry [baseline] (8.853 ms) : 0, 8853
Telemetry [candidate] (8.797 ms) : 0, 8797
Flare Poller [baseline] (3.673 ms) : 0, 3673
Flare Poller [candidate] (3.705 ms) : 0, 3705
ProfilingAgent [baseline] (97.809 ms) : 0, 97809
ProfilingAgent [candidate] (97.125 ms) : 0, 97125
Profiling [baseline] (98.395 ms) : 0, 98395
Profiling [candidate] (97.693 ms) : 0, 97693
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/propagate-force-keep-decision
git_commit_date 1767796928 1767812358
git_commit_sha 7f33e50 8439624
release_version 1.59.0-SNAPSHOT~7f33e50a42 1.59.0-SNAPSHOT~84396240be
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1767814750 1767814750
ci_job_id 1334055475 1334055475
ci_pipeline_id 89524341 89524341
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-70u6fk2v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-70u6fk2v 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~84396240be, baseline=1.59.0-SNAPSHOT~7f33e50a42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.175 ms) : 1164, 1186
.   : milestone, 1175,
iast (3.182 ms) : 3142, 3221
.   : milestone, 3182,
iast_FULL (5.658 ms) : 5602, 5715
.   : milestone, 5658,
iast_GLOBAL (3.48 ms) : 3430, 3530
.   : milestone, 3480,
profiling (2.189 ms) : 2169, 2209
.   : milestone, 2189,
tracing (1.837 ms) : 1820, 1855
.   : milestone, 1837,
section candidate
no_agent (1.185 ms) : 1173, 1196
.   : milestone, 1185,
iast (3.111 ms) : 3067, 3154
.   : milestone, 3111,
iast_FULL (5.729 ms) : 5672, 5785
.   : milestone, 5729,
iast_GLOBAL (3.576 ms) : 3524, 3628
.   : milestone, 3576,
profiling (2.164 ms) : 2144, 2183
.   : milestone, 2164,
tracing (1.776 ms) : 1762, 1790
.   : milestone, 1776,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.175 ms [1.164 ms, 1.186 ms] -
iast 3.182 ms [3.142 ms, 3.221 ms] 2.007 ms (170.8%)
iast_FULL 5.658 ms [5.602 ms, 5.715 ms] 4.483 ms (381.6%)
iast_GLOBAL 3.48 ms [3.43 ms, 3.53 ms] 2.305 ms (196.2%)
profiling 2.189 ms [2.169 ms, 2.209 ms] 1.014 ms (86.3%)
tracing 1.837 ms [1.82 ms, 1.855 ms] 662.235 µs (56.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.185 ms [1.173 ms, 1.196 ms] -
iast 3.111 ms [3.067 ms, 3.154 ms] 1.926 ms (162.6%)
iast_FULL 5.729 ms [5.672 ms, 5.785 ms] 4.544 ms (383.5%)
iast_GLOBAL 3.576 ms [3.524 ms, 3.628 ms] 2.391 ms (201.8%)
profiling 2.164 ms [2.144 ms, 2.183 ms] 978.826 µs (82.6%)
tracing 1.776 ms [1.762 ms, 1.79 ms] 591.273 µs (49.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~84396240be, baseline=1.59.0-SNAPSHOT~7f33e50a42
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.166 ms) : 18970, 19361
.   : milestone, 19166,
appsec (18.392 ms) : 18205, 18578
.   : milestone, 18392,
code_origins (17.553 ms) : 17379, 17727
.   : milestone, 17553,
iast (18.089 ms) : 17907, 18271
.   : milestone, 18089,
profiling (18.798 ms) : 18608, 18987
.   : milestone, 18798,
tracing (17.522 ms) : 17348, 17696
.   : milestone, 17522,
section candidate
no_agent (19.274 ms) : 19077, 19471
.   : milestone, 19274,
appsec (18.412 ms) : 18223, 18601
.   : milestone, 18412,
code_origins (17.723 ms) : 17547, 17899
.   : milestone, 17723,
iast (17.573 ms) : 17398, 17748
.   : milestone, 17573,
profiling (19.725 ms) : 19527, 19923
.   : milestone, 19725,
tracing (17.593 ms) : 17418, 17769
.   : milestone, 17593,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.166 ms [18.97 ms, 19.361 ms] -
appsec 18.392 ms [18.205 ms, 18.578 ms] -774.032 µs (-4.0%)
code_origins 17.553 ms [17.379 ms, 17.727 ms] -1.613 ms (-8.4%)
iast 18.089 ms [17.907 ms, 18.271 ms] -1.077 ms (-5.6%)
profiling 18.798 ms [18.608 ms, 18.987 ms] -368.269 µs (-1.9%)
tracing 17.522 ms [17.348 ms, 17.696 ms] -1.643 ms (-8.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.274 ms [19.077 ms, 19.471 ms] -
appsec 18.412 ms [18.223 ms, 18.601 ms] -861.945 µs (-4.5%)
code_origins 17.723 ms [17.547 ms, 17.899 ms] -1.551 ms (-8.0%)
iast 17.573 ms [17.398 ms, 17.748 ms] -1.701 ms (-8.8%)
profiling 19.725 ms [19.527 ms, 19.923 ms] 450.821 µs (2.3%)
tracing 17.593 ms [17.418 ms, 17.769 ms] -1.681 ms (-8.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/propagate-force-keep-decision
git_commit_date 1767796928 1767812358
git_commit_sha 7f33e50 8439624
release_version 1.59.0-SNAPSHOT~7f33e50a42 1.59.0-SNAPSHOT~84396240be
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1767814495 1767814495
ci_job_id 1334055476 1334055476
ci_pipeline_id 89524341 89524341
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-9yfqq5oq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-9yfqq5oq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~84396240be, baseline=1.59.0-SNAPSHOT~7f33e50a42
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.725 s) : 14725000, 14725000
.   : milestone, 14725000,
appsec (14.828 s) : 14828000, 14828000
.   : milestone, 14828000,
iast (18.259 s) : 18259000, 18259000
.   : milestone, 18259000,
iast_GLOBAL (18.061 s) : 18061000, 18061000
.   : milestone, 18061000,
profiling (14.682 s) : 14682000, 14682000
.   : milestone, 14682000,
tracing (14.476 s) : 14476000, 14476000
.   : milestone, 14476000,
section candidate
no_agent (15.349 s) : 15349000, 15349000
.   : milestone, 15349000,
appsec (14.418 s) : 14418000, 14418000
.   : milestone, 14418000,
iast (18.486 s) : 18486000, 18486000
.   : milestone, 18486000,
iast_GLOBAL (17.944 s) : 17944000, 17944000
.   : milestone, 17944000,
profiling (14.806 s) : 14806000, 14806000
.   : milestone, 14806000,
tracing (14.559 s) : 14559000, 14559000
.   : milestone, 14559000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.725 s [14.725 s, 14.725 s] -
appsec 14.828 s [14.828 s, 14.828 s] 103.0 ms (0.7%)
iast 18.259 s [18.259 s, 18.259 s] 3.534 s (24.0%)
iast_GLOBAL 18.061 s [18.061 s, 18.061 s] 3.336 s (22.7%)
profiling 14.682 s [14.682 s, 14.682 s] -43.0 ms (-0.3%)
tracing 14.476 s [14.476 s, 14.476 s] -249.0 ms (-1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.349 s [15.349 s, 15.349 s] -
appsec 14.418 s [14.418 s, 14.418 s] -931.0 ms (-6.1%)
iast 18.486 s [18.486 s, 18.486 s] 3.137 s (20.4%)
iast_GLOBAL 17.944 s [17.944 s, 17.944 s] 2.595 s (16.9%)
profiling 14.806 s [14.806 s, 14.806 s] -543.0 ms (-3.5%)
tracing 14.559 s [14.559 s, 14.559 s] -790.0 ms (-5.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~84396240be, baseline=1.59.0-SNAPSHOT~7f33e50a42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.472 ms) : 2420, 2525
.   : milestone, 2472,
iast (2.222 ms) : 2157, 2287
.   : milestone, 2222,
iast_GLOBAL (2.271 ms) : 2205, 2336
.   : milestone, 2271,
profiling (2.099 ms) : 2044, 2153
.   : milestone, 2099,
tracing (2.052 ms) : 2001, 2103
.   : milestone, 2052,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.54 ms) : 2485, 2596
.   : milestone, 2540,
iast (2.214 ms) : 2149, 2279
.   : milestone, 2214,
iast_GLOBAL (2.265 ms) : 2200, 2331
.   : milestone, 2265,
profiling (2.06 ms) : 2007, 2112
.   : milestone, 2060,
tracing (2.053 ms) : 2002, 2104
.   : milestone, 2053,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.472 ms [2.42 ms, 2.525 ms] 998.907 µs (67.8%)
iast 2.222 ms [2.157 ms, 2.287 ms] 748.365 µs (50.8%)
iast_GLOBAL 2.271 ms [2.205 ms, 2.336 ms] 797.107 µs (54.1%)
profiling 2.099 ms [2.044 ms, 2.153 ms] 625.362 µs (42.4%)
tracing 2.052 ms [2.001 ms, 2.103 ms] 578.704 µs (39.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.465 ms, 1.488 ms] -
appsec 2.54 ms [2.485 ms, 2.596 ms] 1.064 ms (72.1%)
iast 2.214 ms [2.149 ms, 2.279 ms] 737.869 µs (50.0%)
iast_GLOBAL 2.265 ms [2.2 ms, 2.331 ms] 788.748 µs (53.4%)
profiling 2.06 ms [2.007 ms, 2.112 ms] 583.169 µs (39.5%)
tracing 2.053 ms [2.002 ms, 2.104 ms] 576.825 µs (39.1%)

PerfectSlayer
PerfectSlayer approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good (GitHub diff is weirdly harder to read than expected for mainly a method extraction 🤷 ).

I would recommend writing in the PR description the breaking changes note from now to help the next releaser.

@mcculls mcculls merged commit 419da21 into master Jan 7, 2026
567 checks passed
@mcculls mcculls deleted the mcculls/propagate-force-keep-decision branch January 7, 2026 21:34
@github-actions github-actions bot added this to the 1.59.0 milestone Jan 7, 2026
@mcculls mcculls mentioned this pull request Jan 7, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree ygree approved these changes

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01 mtoffl01 is a code owner automatically assigned from DataDog/apm-sdk-capabilities-java

@genesor genesor Awaiting requested review from genesor

@dougqh dougqh Awaiting requested review from dougqh

Assignees

No one assigned

Labels

comp: context propagation Trace context propagation tag: breaking change Breaking changes type: bug Bug report and fix

Projects

None yet

Milestone

1.59.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mcculls @PerfectSlayer @ygree