1174 le succès dun upload nest pas restitué#1183
Draft
Conversation
yaaax
force-pushed
the
1174-le-succès-dun-upload-nest-pas-restitué
branch
from
8013e92 to
636588b
Compare
bellangerq
requested changes
Sep 24, 2025
Collaborator
bellangerq
left a comment
bellangerq
left a comment
There was a problem hiding this comment.
J'ai review tout le code, pas encore testé fonctionnellement.
Par contre les 9 premiers commits sont pas vraiment liés à la PR 😬
confiture-web-app/src/components/audit/AuditGenerationHeader.vue
Outdated
Show resolved
Hide resolved
confiture-web-app/src/components/audit/CriteriumNotCompliantAccordion.vue
Outdated
Show resolved
Hide resolved
|
|
||
| function handleFileChange() { | ||
| async function handleFileChange() { | ||
| await nextTick(); |
Collaborator
There was a problem hiding this comment.
Je questionne l'utilité d'un nextTick() au tout début d'une fonction ?
… in rendered AuditGenerationPage component. Makes W3C validator happy.
… to make w3c validator happy (p cannot be a child of span)
…without typescript installed globally
…on hide function. Useful when deleting uploaded example images in CriteriumNotCompliantAccordion: on modal conceal, the button that has triggered the modal disclosure does not exist anymore. + clean and improve code
* default formatter: eslint
* use TypeScript tsserver.js installed in node_modules ("typescript"
package)
… composable. * One unique global modal in the App * Uses the DsfrModal * For tbe moment only handles "confirm" use case with 2 action buttons: "confirm" and "cancel" * Uses "useConfirmDialog" composable from vueuse
* Upload / delete files linked to a criterium (example images) * Upload / delete global files (observations) * Handle file upload / file delete errors
… and rework CriteriumNotCompliantAccordion and NotesModal accordingly * Introduce inline delete within Observations modal (because using a modal on top of another modal is forbidden) * Use fileHandler in AuditGenerationCriterium and CriteriumNotCompliantAccordion * Better handle upload/delete errors * More precise confirm messages (using file name)
yaaax
force-pushed
the
1174-le-succès-dun-upload-nest-pas-restitué
branch
from
c5e55cb to
e9a7256
Compare
+ remove one extra useResultsStore in AuditGenerationHeader
Collaborator
Author
J’ai revu l’ensemble des commentaires. Pour ce qui est des commits de "clean", j’ai effectivement un peu débordé 🫤 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1174
Avant de merger la pull request, s’assurer que :