Confirm outdated review comment on _parse_network_input is no longer applicable#587
Closed
Copilot wants to merge 2 commits intojapr/network-supportfrom
Closed
Confirm outdated review comment on _parse_network_input is no longer applicable#587Copilot wants to merge 2 commits intojapr/network-supportfrom
_parse_network_input is no longer applicable#587Copilot wants to merge 2 commits intojapr/network-supportfrom
Conversation
Copilot
AI
changed the title
[WIP] Address feedback on network support in Japr PR #586
Confirm outdated review comment on Feb 20, 2026
_parse_network_input is no longer applicable
Contributor
|
@copilot run mypy and solve the errors |
Co-authored-by: jpalm3r <28826351+jpalm3r@users.noreply.github.com>
Author
Fixed in commit 5550ee8. Resolved all 19 mypy errors:
|
Contributor
|
Closed since it is obsolete. The issues here were solved in #586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeObservation.nodereturn type toOptional[int]NetworkObservation.nodeslist comprehension to filterNonevaluesNoneguard inNodeModelResult.nodebefore calling.item()SpatialFieldinheritance fromNetworkModelResult(incompatibleextract()signature)matching.pywith propercast()calls and explicitraw_mod_datatypeNetworkModelResultfromraw_mod_datatype union inComparer(after extraction it becomesNodeModelResult)_to_model()return type to includeNodeModelResultload()method type annotation inComparer✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.