Remove _to_observation and _to_model from Comparer#567
Open
ecomodeller wants to merge 1 commit intomainfrom
Open
Remove _to_observation and _to_model from Comparer#567ecomodeller wants to merge 1 commit intomainfrom
ecomodeller wants to merge 1 commit intomainfrom
Conversation
These methods existed only to support spatial_overview and temporal_coverage plotting. Now these functions work directly with Comparers via duck typing (using gtype, x, y, name, time properties), making it easier to add new observation types without modifying Comparer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_to_observation()and_to_model()methods from Comparerspatial_overviewandtemporal_coveragenow work directly with Comparers via duck typinggtypeproperty instead ofisinstance()checks, making it easier to add new observation typesFollow-up to #565 which removed value-based coloring to enable this refactor.