This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
========================================
Coverage 20.8% 20.8%
Complexity 99 99
========================================
Files 79 79
Lines 1245 1245
Branches 177 177
========================================
Hits 259 259
Misses 913 913
Partials 73 73Continue to review full report at Codecov.
|
harrischristiansen
suggested changes
Apr 3, 2018
Member
harrischristiansen
left a comment
harrischristiansen
left a comment
There was a problem hiding this comment.
We should move this to the backend (which sends out our email notifications). It should be placed in backend/resources/views/emails, and test emails can be generated and sent to test formatting in a mail client.
Also, emails cannot reference an external css file, especially by relative path.
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge"> | ||
| <title>Document</title> | ||
| <link rel="stylesheet" href="styles/email.css"> |
Member
There was a problem hiding this comment.
Emails cannot reference an external css file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.