Fix bug in Fortran dataset destructor#525
Merged
ashao merged 2 commits intoCrayLabs:developfrom Sep 10, 2025
Merged
Conversation
4f5471e to
f7c9cd5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #525 +/- ##
============================================
- Coverage 95.92% 57.63% -38.30%
============================================
Files 10 147 +137
Lines 884 11908 +11024
Branches 0 1131 +1131
============================================
+ Hits 848 6863 +6015
- Misses 36 4894 +4858
- Partials 0 151 +151
🚀 New features to boost your workflow:
|
f7c9cd5 to
19ec3ea
Compare
al-rigazzi
approved these changes
Jun 17, 2025
Collaborator
al-rigazzi
left a comment
There was a problem hiding this comment.
One minor typo in the changelog, but approving as it looks good otherwise. Thanks for fixing this user issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Fortran client where (on compilers that support automatic destruction) the program would segfault if the user had manually destroyed the dataset. This behaviour was tracked down to an error in the C-client where only the one-level de-referenced pointer was being set to
NULLbut not the actual double-pointer.