Skip to content

Conversation

@inpercima
Copy link
Member

@inpercima inpercima commented May 4, 2025

This PR moves the experimental web to used web interface for lvz-viz.

There was a need to add the .gitattributes for *.bat files, otherwise the following gradle check will fail.
As a result, the gradlew.bat was also checked in again.

> Task :editorconfigCheck FAILED
gradlew.bat@1,5: Insert cr - violates end_of_line = crlf, reported by org.ec4j.linters.TextLinter
gradlew.bat@2,52: Insert cr - violates end_of_line = crlf, reported by org.ec4j.linters.TextLinter

The problem with gradlew.bat deosn't exists anymore.

@inpercima inpercima force-pushed the use-experimental-web-as-default branch 2 times, most recently from 2f1c6f5 to c370c77 Compare May 5, 2025 21:18
@inpercima inpercima force-pushed the use-experimental-web-as-default branch from c370c77 to 68431da Compare May 31, 2025 05:24
@inpercima inpercima marked this pull request as ready for review May 31, 2025 06:04
@inpercima inpercima requested a review from sepe81 May 31, 2025 06:04
@inpercima inpercima force-pushed the use-experimental-web-as-default branch from a90d777 to 9355757 Compare May 31, 2025 08:41
@inpercima
Copy link
Member Author

inpercima commented Jun 15, 2025

Hey @sepe81 maybe you have some little time to check this PR in small steps? Maybe you have an idea about the changes in gradlew.bat (EOL) and what do you think about the basic idea of how it is done in this PR with the frontend/backend split?

@inpercima
Copy link
Member Author

The most changes here are the move from root to backend and the removal of the now unused "old" frontend.

@inpercima inpercima force-pushed the use-experimental-web-as-default branch from 9355757 to 758dd74 Compare July 9, 2025 07:01
@inpercima inpercima marked this pull request as draft November 8, 2025 20:43
@inpercima inpercima removed the request for review from sepe81 November 8, 2025 20:43
@inpercima inpercima force-pushed the use-experimental-web-as-default branch from 758dd74 to 3861d34 Compare November 8, 2025 20:52
@sepe81 sepe81 requested a review from Copilot December 27, 2025 13:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the project from the legacy Angular.js frontend to the modern Angular (experimental_web) frontend as the default implementation. The changes consolidate the two separate web implementations into a single modern frontend-backend architecture.

Key changes:

  • Removed legacy Angular.js frontend files and replaced with Angular frontend as default
  • Restructured project to use frontend/backend subdirectories with improved documentation
  • Updated build configuration and CI workflows to support the new structure

Reviewed changes

Copilot reviewed 33 out of 124 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/main/resources/public/* Removed all legacy Angular.js frontend files (HTML, JS, CSS)
frontend/* Updated frontend configuration to support production deployment and proxy setup
backend/* Added build tasks for frontend integration and updated editorconfig excludes
package.json Updated root package.json with new author information and development scripts
README.md Restructured documentation to reflect new frontend-backend architecture
.github/workflows/* Updated CI workflows for new directory structure
.gitattributes Added to enforce CRLF line endings for .bat files
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


task buildFrontend(type: Exec) {
workingDir '../frontend'
commandLine 'pnpm', 'run', 'build:prod'
Copy link

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buildFrontend task should include error handling or validation to ensure pnpm is available on the system before execution. Consider adding a doFirst block to check for pnpm availability and provide a helpful error message if it's missing.

Suggested change
commandLine 'pnpm', 'run', 'build:prod'
commandLine 'pnpm', 'run', 'build:prod'
doFirst {
def stdout = new ByteArrayOutputStream()
def stderr = new ByteArrayOutputStream()
def result = project.exec {
commandLine 'pnpm', '--version'
standardOutput = stdout
errorOutput = stderr
ignoreExitValue = true
}
if (result.exitValue != 0) {
throw new GradleException(
"pnpm is required to build the frontend but was not found on the PATH. " +
"Please install pnpm (see https://pnpm.io/installation) and try running the build again."
)
}
}

Copilot uses AI. Check for mistakes.
Comment on lines +86 to +100
this.searchService.fetch(pageIndex, pageSize, 'datePublished,desc', this.searchTerm).subscribe((response) => {
this.totalElements = response.totalElements;
this.dataSource = new MatTableDataSource(response.content);
this.addToMap(response.content);
});
Copy link

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subscription in loadPage lacks error handling. Add an error callback to handle potential HTTP errors gracefully and provide user feedback when data fetching fails.

Suggested change
this.searchService.fetch(pageIndex, pageSize, 'datePublished,desc', this.searchTerm).subscribe((response) => {
this.totalElements = response.totalElements;
this.dataSource = new MatTableDataSource(response.content);
this.addToMap(response.content);
});
this.searchService
.fetch(pageIndex, pageSize, 'datePublished,desc', this.searchTerm)
.subscribe({
next: (response) => {
this.totalElements = response.totalElements;
this.dataSource = new MatTableDataSource(response.content);
this.addToMap(response.content);
},
error: (error) => {
// Log the error for debugging purposes
// eslint-disable-next-line no-console
console.error('Failed to load page data', error);
// Provide basic user feedback
window.alert('Failed to load data from the server. Please try again later.');
},
});

Copilot uses AI. Check for mistakes.
@sepe81 sepe81 self-requested a review December 27, 2025 13:05
Copy link
Member

@sepe81 sepe81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inpercima Could you please rebase with main and resolve the conflicts so we can continue with local testing?

@sepe81
Copy link
Member

sepe81 commented Dec 28, 2025

Hey @sepe81 maybe you have some little time to check this PR in small steps? Maybe you have an idea about the changes in gradlew.bat (EOL) and what do you think about the basic idea of how it is done in this PR with the frontend/backend split?

May we keep the backend in the root directory without an extra subfolder to simplify the restructuring and the local Java build?

@inpercima
Copy link
Member Author

This PR is from May, therefore I will rewrite it and adapt some things to current conditions.

May we keep the backend in the root directory without an extra subfolder to simplify the restructuring and the local Java build?

Is the problem an IDE dependency? Your IDE or some other plugins/extensions search java for the root?

Then I will change that.
The idea was to just separate the Frontend and Backend so they could be developed separately.
If that causes problems in different scenarios, then we'll do it the way you suggested for now and see about separating them later.

@sepe81
Copy link
Member

sepe81 commented Dec 29, 2025

Is the problem an IDE dependency? Your IDE or some other plugins/extensions search java for the root?

I think it’s more natural to run Gradle in the root of the project instead of constantly switching between the frontend and backend folders. The main build doesn’t require any directory switching.

Furthermore, it reduces the complexity of the changes in this PR.

@inpercima inpercima force-pushed the use-experimental-web-as-default branch from 3861d34 to 0558536 Compare January 2, 2026 09:19
@inpercima inpercima force-pushed the use-experimental-web-as-default branch from 0558536 to 9e93ac4 Compare January 2, 2026 09:25
@inpercima inpercima force-pushed the use-experimental-web-as-default branch from c9d0ae1 to df56e56 Compare January 2, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants