ci: fix Codecov on main #3255
Merged
ci: fix Codecov on main #3255
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 3020c55 ☁️ Nx Cloud last updated this comment at |
jakemhiller
approved these changes
Jan 29, 2026
jakemhiller
reviewed
Jan 29, 2026
| npx nx run-many --target=test --all --parallel=4 --ci --coverage --runInBand --skip-nx-cache | ||
| else | ||
| npx nx run-many --target=test --all --parallel=4 --ci --coverage --runInBand | ||
| npx nx affected --target=test --parallel=4 --ci --coverage --runInBand |
Member
There was a problem hiding this comment.
we might want to add https://github.com/nrwl/nx-set-shas above in this workflow, or add it to the yarn shared action so it happens consistently. It just normalizes the shas used for affected in various GHA cases where they might get messed up.
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://697b822936082b12fce77c19--gamut-preview.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips the NX cache on
maintests to guarantee that coverage always exists for it. I also refactored the conditional logic because the semantics weren't quite right but that it'll have the same effect.PR Checklist