London | 26-ITP-JAN | Shuheda Begum | Sprint 1 | Structuring and Testing Data by codebyshay · Pull Request #937 · CodeYourFuture/Module-Structuring-and-Testing-Data

codebyshay · 2026-02-07T16:25:06Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Did exercise 1.

Questions

N/A

Initials fixed

const dir and const ext

What does num represent with explanation

Adding // to make a comment or add instructions for human consumption.

let allows variable age, const does not.

Swapped the position of const from under the console to on top of the console to allow javascript to read it in order.

Add String to the cardNumber so javascript recognises it as a string and not just numbers, making it possible to slice.

SyntaxError fixed..twelve instead of 12 and twentyFour instead of 24

Answered all questions and added , to the function.

Answered questions

Explain each step one by one.

Answered questions and tried alert and prompt on chrome dev tool.

Completed dev tool exercise on chrome.

Theoreoluwa · 2026-02-18T01:49:51Z

Sprint-1/2-mandatory-errors/1.js

+
+// The code above will output 34, because we are reassigning the value of age to be the current value of age plus 1. So, 33 + 1 = 34.
+


Do you think the explanation provided here hit the major reason why the error was occurring even if you did the right thing in your code?

No. I have now included this . Thank you.

Theoreoluwa · 2026-02-18T01:50:30Z

Sprint-1/2-mandatory-errors/3.js

@@ -1,9 +1,12 @@
 const cardNumber = 4533787178994213;
-const last4Digits = cardNumber.slice(-4);
+const last4Digits = String(cardNumber).slice(-4);


Now, you did the right thing by explaining your reasoning to debug the error. I would suggest applying a much cleaner way to convert the variable into a string without redeclaring it. You can look into that method using MDN docs.

Ok, thank you.

Theoreoluwa · 2026-02-18T01:54:09Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+
 // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
+
+// This code will work for all positive integer values of movieLength. It will correctly calculate the hours, minutes and seconds for any length of movie. However, if movieLength is negative or not an integer, the code may not work as intended. For example, if movieLength is -100, the calculations will not make sense in the context of a movie length. If movieLength is a decimal, it may also cause issues with the calculations.


Have you considered if there could be some time formatting issues with smaller integer numbers?

I didn't think of that. I will have a look at this now.

Theoreoluwa

Great job so far; kindly look into the comments to make it better. Well done.

Code amended to allow shorter times.

codebyshay · 2026-02-21T16:31:47Z

Thank you. I've looked though the comments and have amended as necessary.

Theoreoluwa · 2026-02-24T23:26:50Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+
+const movieLength = 65;
+
+const remainingSeconds = movieLength % 60;
+const totalMinutes = (movieLength - remainingSeconds) / 60;
+
+const remainingMinutes = totalMinutes % 60;
+const totalHours = (totalMinutes - remainingMinutes) / 60;
+
+const formattedHours = String(totalHours).padStart(2, "0");
+const formattedMinutes = String(remainingMinutes).padStart(2, "0");
+const formattedSeconds = String(remainingSeconds).padStart(2, "0");
+
+const movieDurationString = `${formattedHours}:${formattedMinutes}:${formattedSeconds}`;
+
+console.log(movieDurationString); // 00:01:05


While I understand you might have misinterpreted my comment, the point I made was not for an explicit change of the code to work with a certain range of numbers. The rationale, as seen in the task, is to explain your rationale for your answer as to how various values will work when passed into the movieLength variable.

Theoreoluwa

Well done. Great job. I will mark the task as complete, but I would encourage you to check through my comment and ensure you understand the task requirements properly. Keep going!

codebyshay added 16 commits February 7, 2026 16:21

Did 1-count.js

c82ecac

Testing commit via terminal

13c3a8a

testing reversal

3dae4d0

Update 2-initials.js

f4adea0

Initials fixed

Update 3-paths.js

9f0fe23

const dir and const ext

Update 4-random.js

7d2f848

What does num represent with explanation

Update 0.js

9c2b2fc

Adding // to make a comment or add instructions for human consumption.

const to let

c557dca

let allows variable age, const does not.

Console and const

704d372

Swapped the position of const from under the console to on top of the console to allow javascript to read it in order.

Update 3.js

3d0ea75

Add String to the cardNumber so javascript recognises it as a string and not just numbers, making it possible to slice.

Update 4.js

c611ae5

SyntaxError fixed..twelve instead of 12 and twentyFour instead of 24

Update 1-percentage-change.js

978fdbf

Answered all questions and added , to the function.

Update 2-time-format.js

22aca43

Answered questions

Update 3-to-pounds.js

499906a

Explain each step one by one.

Update chrome.md

6cb823c

Answered questions and tried alert and prompt on chrome dev tool.

Update objects.md

2fd76d2

Completed dev tool exercise on chrome.

codebyshay added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026

Theoreoluwa added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 18, 2026

Theoreoluwa reviewed Feb 18, 2026

View reviewed changes

Theoreoluwa added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 18, 2026

codebyshay added 3 commits February 21, 2026 15:25

update error

4c474e3

Cleaner code

4a41676

Update 2-time-format.js

2e95c35

Code amended to allow shorter times.

codebyshay added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 21, 2026

Theoreoluwa added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 24, 2026

Theoreoluwa reviewed Feb 24, 2026

View reviewed changes

Theoreoluwa added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

London | 26-ITP-JAN | Shuheda Begum | Sprint 1 | Structuring and Testing Data#937

London | 26-ITP-JAN | Shuheda Begum | Sprint 1 | Structuring and Testing Data#937
codebyshay wants to merge 19 commits intoCodeYourFuture:mainfrom
codebyshay:coursework/sprint-1

codebyshay commented Feb 7, 2026

Uh oh!

Theoreoluwa Feb 18, 2026

Uh oh!

codebyshay Feb 21, 2026

Uh oh!

Theoreoluwa Feb 18, 2026

Uh oh!

codebyshay Feb 21, 2026

Uh oh!

Theoreoluwa Feb 18, 2026

Uh oh!

codebyshay Feb 21, 2026

Uh oh!

Theoreoluwa left a comment

Uh oh!

codebyshay commented Feb 21, 2026

Uh oh!

Theoreoluwa Feb 24, 2026

Uh oh!

Theoreoluwa left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		// The code above will output 34, because we are reassigning the value of age to be the current value of age plus 1. So, 33 + 1 = 34.


		// f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer

		// This code will work for all positive integer values of movieLength. It will correctly calculate the hours, minutes and seconds for any length of movie. However, if movieLength is negative or not an integer, the code may not work as intended. For example, if movieLength is -100, the calculations will not make sense in the context of a movie length. If movieLength is a decimal, it may also cause issues with the calculations. No newline at end of file

Uh oh!

Comments

Conversation

codebyshay commented Feb 7, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

Theoreoluwa Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

codebyshay Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

codebyshay Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

codebyshay Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa left a comment

Choose a reason for hiding this comment

Uh oh!

codebyshay commented Feb 21, 2026

Uh oh!

Theoreoluwa Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants