London | 26-ITP-Jan | Raihan Sharif | Sprint 2 | form control#1202
Open
RaihanSharif wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Raihan Sharif | Sprint 2 | form control#1202RaihanSharif wants to merge 2 commits intoCodeYourFuture:mainfrom
RaihanSharif wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
RaihanSharif
added
the
Needs Review
cjyuan
reviewed
Feb 25, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
Most labels in a HTML form begin with an uppercase letter. Can yo use an AI tool to find out why it is better that way?
Comment on lines
37
to
45
| <select | ||
| name="shirt-color" | ||
| id="shirt-color" | ||
| aria-label="select shirt color" | ||
| required> | ||
| <option value="red">red</option> | ||
| <option value="red">green</option> | ||
| <option value="red">blue</option> | ||
| </select> |
Contributor
There was a problem hiding this comment.
Can you configure the <select> element so that no option is selected by default, and thus allowing the user to make an explicit choice?
Also, the options are not marked up correctly. (Copy-paste error)
cjyuan
added
Reviewed
Select element now does not select one of the values by default. Also chose not to remove trailing / in void elements. As prettier does not allow this. Would require installing and configuring an unmaintained extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Created form with relevant inputs, validations and accessibility with aria-labels.