Skip to content

Manchester | 26-ITP-Jan | Liban Jama | Sprint 2 | Form-Controls #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
libanj0161 wants to merge 12 commits into
base: main
Choose a base branch
from
+91 −27
Open

Manchester | 26-ITP-Jan | Liban Jama | Sprint 2 | Form-Controls #1082

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e4a809e
created-form
libanj0161 Jan 27, 2026
cde3708
added dropdown menu for sizes and added minlength and required on inputs
libanj0161 Jan 28, 2026
d30df10
updated after feedback
libanj0161 Feb 2, 2026
bc15017
made changes as per pr comments
libanj0161 Feb 6, 2026
695b741
new changes
libanj0161 Feb 14, 2026
eb52899
added label to the select option
libanj0161 Feb 20, 2026
4b6f135
removed max length for name and email
libanj0161 Feb 20, 2026
0cb58d5
wrapped radio buttons in fieldset and changed colour in a <p> to <leg…
libanj0161 Feb 21, 2026
283cee5
updated after feedback
libanj0161 Feb 22, 2026
891159d
updated to meet lighthouse accessibility
libanj0161 Feb 22, 2026
66123f0
additional changes
libanj0161 Feb 22, 2026
3277e6e
changed p tags to div tags
libanj0161 Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 91 additions & 27 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,91 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>
</html>
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>My form exercise</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
</head>

<body>
<header>
<h1>Product Pick</h1>
</header>

<main>
<form>

<!-- Name input -->
<div>
<label for="name">Name</label><br>
<input type="text" id="name" name="user_name"
placeholder="John Smith"
required minlength="2">
</div>
<br>

<!-- Email input -->
<div>
<label for="email">Email</label><br>
<input type="email" id="email" name="user_email"
placeholder="johnsmith@hotmail.com"
required minlength="5">
</div>
<br>

<!-- Colour selection -->
<fieldset>
<legend>Colour</legend>

<div>
<label>
<input type="radio" name="colour" value="red" required>
Red
</label>
</div>
<div>
<label>
<input type="radio" name="colour" value="blue">
Blue
</label>
</div>
<div>
<label>
<input type="radio" name="colour" value="green">
Green
</label>
</div>
</fieldset>
<br>

<!-- Size selection -->
<fieldset>
<legend>Select Size</legend>

<div>
<select id="size" name="size" required>
<option value="" selected disabled>Select a size</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</div>
</fieldset>
<br>

<!-- Submit button -->
<div>
<button type="submit">Submit</button>
</div>

</form>
</main>

<footer>
<p>By LIBAN JAMA</p>
</footer>
Comment on lines 86 to 88
Copy link
Contributor

@cjyuan cjyuan Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headings (<h1>–<h6>) are meant to label sections of content.

Use of <h2> would make "By LIBAN JAMA" sounds like a header of a major section to a screen reader and to search engines. <p> is probably more appropriate here.


</body>
</html>