West Midlands | ITP-January-2026 | Jonathan Boahene | Sprint 1 | Wireframe#1035
West Midlands | ITP-January-2026 | Jonathan Boahene | Sprint 1 | Wireframe#1035Abayie wants to merge 10 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Abayie
added
the
Needs Review
illicitonion
added
Review in progress
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This generally looks good, but your footer is a bit off - compare what it looks like in the wireframe to your website - they look a bit different. Can you debug?
| <a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
You've left the alt attribute of these <img> tags empty. Sometimes that's the right thing to do, but only in very specific circumstances - can you talk through why you think they should be empty here?
There was a problem hiding this comment.
I left the alt attributes empty because these images are currently decorative placeholders and don’t convey any meaningful content or functionality to users, so they’re intentionally hidden from screen readers to avoid noise
| </p> | ||
| <a href="https://www.coursera.org/gb/articles/wireframe">Read more</a> | ||
| </article> | ||
| <article> |
There was a problem hiding this comment.
Nice use of semantic HTML tags throughout this PR!
Wireframe/style.css
Outdated
| body { | ||
| display: flex; | ||
| flex-direction: column; | ||
| min-height:100vh; |
There was a problem hiding this comment.
This line looks formatted slightly differently to the others - the others have spaces after the :s and this doesn't - can you fix that up? Maybe there is some tooling which can help us automatically format files - worth some research!
There was a problem hiding this comment.
I’ve updated the spacing to match the rest of the file for consistency.
I’ll also look into adding an auto-formatter (e.g. Prettier) to keep styling consistent across the project going forward, I have had prettier but not sure why that wasn't formatted earlier
illicitonion
added
Reviewed
Abayie
added
the
Needs Review
allows the footer to stay at the bottom of page
In the past I tried to show the footer in the viewport |
Abayie
removed
the
Reviewed
|
Changes look good. It seems all comments have been addressed. |
cjyuan
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
Wireframe coursework around semantic html structure
Questions
No questions