Skip to content

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 2 | Implement a linked list in Python#124

Closed
HassanOHOsman wants to merge 22 commits intoCodeYourFuture:mainfrom
HassanOHOsman:implement/linked-list-in-Python
Closed

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 2 | Implement a linked list in Python#124
HassanOHOsman wants to merge 22 commits intoCodeYourFuture:mainfrom
HassanOHOsman:implement/linked-list-in-Python

Conversation

@HassanOHOsman
Copy link

@HassanOHOsman HassanOHOsman commented Feb 26, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

In this pull request, I implemented a linked list with push_head, pop_tail, and remove operations, all in O(1) time.

@HassanOHOsman
create a Node class that stores the value of the data it contains and…
5e178ad 
… references to both previous and next nodes
@HassanOHOsman
Create anthor class that models the linked list
d699eeb
@HassanOHOsman
define a function that push a new node to the beginning of the linked…
2886aeb 
… list + create a node object to represents that node that will become the new head
@HassanOHOsman
check if the linked list have nodes, if so, appoints the new object t…
1e691d7 
…o become head of the linked list.
@HassanOHOsman
update the "former" head node's prev pointer to point to the new head…
1ccff69 
… ndoe
@HassanOHOsman
make the new created node as the head node incase that the linked lis…
361c2e3 
…t is empty
@HassanOHOsman
update logic so that it check if the linked list is empty if so to th…
609ccd1 
…e new created ndoes becomes the tail node too
@HassanOHOsman
create pop_tail function that checks if the linked list has nodes in …
f7ef01c 
…it, if so, disconnect the tail so it gets removed.
@HassanOHOsman
when linekd array has nodes, udpate pointers to get rid of the tail.
8daafeb
@HassanOHOsman
move the pointer to tail node to point the the previous node
6abcd50
@HassanOHOsman
after repositioning pointer of last node towards the seond to last no…
4518f34 
…de., disconnect from the node that comes after it (initial tail node)
@HassanOHOsman
add if condition so that logic handles when linked list has more than…
8718bde 
… one node in it.
@HassanOHOsman
update logic to handle when linked list is empty: Throw an error
6bce59e
@HassanOHOsman
add a return to pop_tail to pass tests
97552b4
@HassanOHOsman
update pop_tail function to handle when there's one node in the linke…
1a94c7e 
…d list
@HassanOHOsman
since test require "previous", replacing all mentions to "prev" with …
5664fdd 
…"previous" so that tests pass
@HassanOHOsman
build remove function - make it check if there's a node before our cu…
b68f803 
…rrent node - if so reposition pointer so it's disconnected from the linked list
@HassanOHOsman
update logic inside remove function so that when the current node is …
3139f6d 
…the head, the next node becomes the new head and thus current node disconnected and removed from linked list.
@HassanOHOsman
updat remove function to handle when node points to other next node i…
aec7441 
…n the linked list - if so reposition pointers so curent node is removed. else if the current node is the tail make the previous node to it the "new" tail
@HassanOHOsman
ignore VM for Sprint 2
a9ee5b0
@HassanOHOsman
create a branch so that pull request can be pushed
f54da60
@github-actions
Copy link

github-actions bot commented Feb 26, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@HassanOHOsman HassanOHOsman added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 26, 2026
@github-actions
Copy link

github-actions bot commented Feb 26, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 26, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 26, 2026
@HassanOHOsman HassanOHOsman changed the title Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | Implement a linked list in Python Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 2 | Implement a linked list in Python Feb 26, 2026
@github-actions
Copy link

github-actions bot commented Feb 26, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/implement_linked_list/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@HassanOHOsman HassanOHOsman added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 26, 2026
@github-actions
Copy link

github-actions bot commented Feb 26, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/implement_linked_list/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 26, 2026
@HassanOHOsman HassanOHOsman added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 27, 2026
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/implement_linked_list/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 27, 2026
@HassanOHOsman HassanOHOsman added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 27, 2026
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/implement_linked_list/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HassanOHOsman