refactor: 💡 reconcile SVG assets (Flags, Icons, Logos and Payments)#834
Merged
refactor: 💡 reconcile SVG assets (Flags, Icons, Logos and Payments)#834
Conversation
…WS_S3 -> aws-s3; to respect original naming
…nd auto generation
punkbit
changed the title
gjones
approved these changes
Feb 18, 2026
Collaborator
|
Overall, looks good to me and seems to work as expected. Thanks! |
Base automatically changed from
chore/svg-to-react-component-converter
to
main
February 18, 2026 15:24
Properly merged main while preserving all enhancements from the refactor/reconcile-svg-assets branch: - Kept all 4 convert scripts in package.json (logo, icon, flag, payment) - Preserved multi-asset type support in SVG converter - Maintained Assets/ directory structure for all asset types - All 328 tests passing
punkbit
force-pushed
the
refactor/reconcile-svg-assets
branch
from
eabba51 to
667a6ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Reconciles SVG asset management for Flags, Icons, and Logos by restructuring file locations for React SVG components to match the conventions established in the original SVG-to-React conversion (#828).
It also modifies the original SVG to React Component process to support all three asset types: Flags, Icons, Logos and Payments. Included some safeguards, to try to help enforce naming conventions to facilitate. This bit might require further attempts, as it relies on the same retroactive~mapping to old names encountered or established in the Logo conversation version.
For now, this second iterative pass creates a consistent asset management flow across all three asset types.
🤖 Change base to main once #828 is merged
How?
src/components/Assets/Tickets?
Preview?
### Convert Icons
demo-convert-icons.mov
Convert Flags
demo-convert-flags.mov
Convert Logos
demo-convert-logos.mov
Convert Payments
demo-convert-payment.mov
Flags
Logo
Icons