Open
Conversation
dwapstra
reviewed
May 25, 2023
docs/manifest/introduction.rst
Outdated
Comment on lines
+42
to
+44
| In case the associated script file is in a different location from the manifest you could use a symlink | ||
| to refering the script. To change the default behavior for using the symlink and change where to execute | ||
| the script you need to pass --follow-symlink. |
Contributor
There was a problem hiding this comment.
Suggested change
| In case the associated script file is in a different location from the manifest you could use a symlink | |
| to refering the script. To change the default behavior for using the symlink and change where to execute | |
| the script you need to pass --follow-symlink. | |
| In case the associated job file is in a different location from the manifest you can use a symlink | |
| to refer to the job.py file. By default the job will be executed in the directory where the manifest | |
| file is located. To change the execution directory and use the symlink target directory to execute | |
| the script you need to pass --follow-symlink. |
dwapstra
reviewed
May 25, 2023
ThomasJRyan
requested changes
Nov 28, 2023
ThomasJRyan
approved these changes
Nov 28, 2023
dwapstra
reviewed
Nov 28, 2023
|
|
||
| $ pyats run manifest job.tem --follow-symlink | ||
|
|
||
| $ job.py # is a symlink for the associated script |
Contributor
There was a problem hiding this comment.
Please show symlink from the filesystem, e.g.
ls -l job.py
lrwxr-xr-x 1 admin wheel 20 Nov 29 11:36 job.py -> /tmp/job/path/job.py
This job will be executed in the /tmp/job/path directory.
There was a problem hiding this comment.
Please show symlink from the filesystem, e.g.
ls -l job.py lrwxr-xr-x 1 admin wheel 20 Nov 29 11:36 job.py -> /tmp/job/path/job.pyThis job will be executed in the
/tmp/job/pathdirectory.
@omehrabi
Did you see this note from a reviewer?
dwapstra
requested changes
Nov 28, 2023
Contributor
dwapstra
left a comment
There was a problem hiding this comment.
Please update the doc with example symlink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add documentation for follow-symlink to use a symlink for the job