Skip to content

fix(flags): sanitizing leading and trailing spaces from multi string flags #7761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cx-laura-rodrigues wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(flags): sanitizing leading and trailing spaces from multi string flags #7761

cx-laura-rodrigues wants to merge 3 commits into from

Conversation

@cx-laura-rodrigues
Copy link
Contributor

@cx-laura-rodrigues cx-laura-rodrigues commented Oct 8, 2025

Proposed Changes

  • Added sanitization to multi string flags when arguments have spaces separating them
  • Added unit test to multi string flags test

I submit this contribution under the Apache-2.0 license.

@cx-laura-rodrigues cx-laura-rodrigues requested a review from a team as a code owner October 8, 2025 17:28
@github-actions github-actions bot added the community Community contribution label Oct 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

kics-logo

KICS version: v2.1.13

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

cx-artur-ribeiro
cx-artur-ribeiro approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cx-laura-rodrigues,
From what I've seen and from the tests I ran locally on your branch, everything looks good to me 😄.
We still can’t use spaces unless we wrap the value in quotation marks ("), but as we discussed, and based on the research I did, this seems to be a limitation of Cobra itself.

I’ll bring this up with the rest of the team and see what they think!

Thanks for the great work!

cx-rui-araujo
cx-rui-araujo approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@cx-rui-araujo cx-rui-araujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-rui-araujo cx-rui-araujo cx-rui-araujo approved these changes

@cx-artur-ribeiro cx-artur-ribeiro cx-artur-ribeiro approved these changes

Assignees

@cx-laura-rodrigues cx-laura-rodrigues

Labels

community Community contribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cx-laura-rodrigues @cx-rui-araujo @cx-artur-ribeiro