-
Notifications
You must be signed in to change notification settings - Fork 44
Remove resigned committee and add new #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -84,13 +84,23 @@ people: | |||||
| role: Socials Secretary | ||||||
| picture: /assets/committee/2025-26/mini/fearne.jpg | ||||||
| start-date: 1/7/2025 | ||||||
| end-date: 11/02/2026 | ||||||
| bio: > | ||||||
| Hellooooo, I'm Fearne your new socials sec. I'll be putting together | ||||||
| some hopefully fun and super duper cool and awesome socials for you. | ||||||
| Please come along and say hi :) | ||||||
| I'm going into my third year in CS and first year in committee. | ||||||
| If your favourite colour is pink I think we'll be great friends | ||||||
|
|
||||||
|
|
||||||
| - name: Misha | ||||||
| discordtag: mxg586 | ||||||
| pronouns: he/him | ||||||
| role: Socials Secretary | ||||||
| picture: /assets/committee/2025-26/mini/misha.jpg | ||||||
|
||||||
| picture: /assets/committee/2025-26/mini/misha.jpg | |
| picture: /assets/committee/2025-26/mini/fearne.jpg |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start-date: 11/02/2026 is ambiguous for Liquid/Ruby date parsing (could be interpreted as Nov 2 or Feb 11). Use an unambiguous ISO-8601 date string (e.g. 2026-02-11) so the Committee page renders the correct month.
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end-date values are parsed via Liquid's date filter in committee.html, and 11/02/2026 is ambiguous (could be 11 Feb or 2 Nov depending on parser). Use an unambiguous ISO-8601 date string (e.g. 2026-02-11) to ensure correct rendering/sorting.
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
picture points to /assets/committee/2025-26/mini/lee.jpg, but that file does not exist in assets/committee/2025-26/mini/ (and there is no corresponding file in assets/committee/2025-26/full/ either). This will produce a broken image on the Committee page; add the image assets (full + generated mini) or update the path to an existing image.
| picture: /assets/committee/2025-26/mini/lee.jpg |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start-date: 11/02/2026 is ambiguous for Liquid/Ruby date parsing (could be interpreted as Nov 2 or Feb 11). Use an unambiguous ISO-8601 date string (e.g. 2026-02-11) so the Committee page renders the correct month.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end-datevalues are parsed via Liquid'sdatefilter incommittee.html, and11/02/2026is ambiguous (could be 11 Feb or 2 Nov depending on parser). To avoid incorrect month/year display, use an unambiguous format like ISO-8601 (2026-02-11) for committee start/end dates.