Skip to content

Conversation

@Hell1213
Copy link
Contributor

Description
Fixed delete all tasks dialog closing immediately and freezing screen by restoring proper DialogTrigger pattern with onSelect={(e) => e.preventDefault()} to match other dialogs in NavbarDesktop component.

Fixes: #321

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes
Dialog now works correctly without screen freeze. Solution follows existing code patterns used by Export and DevLogs dialogs in the same component.

Demo

Screencast.from.2025-12-27.21-03-44.mp4

@github-actions
Copy link

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

Copy link
Contributor Author

@Hell1213 Hell1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored proper DialogTrigger pattern with onSelect={(e) => e.preventDefault()}

@its-me-abhishek its-me-abhishek changed the title Fix delete all tasks dialog state conflict fix: delete all tasks dialog state conflict Dec 27, 2025
@its-me-abhishek its-me-abhishek merged commit c783157 into CCExtractor:main Dec 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Clicking on Delete all tasks dialog closes the dialog immediately and freezes the screen

2 participants