Create of a Credentials class in order to have to authenticate only o…#337
Open
joaomfrebelo wants to merge 1 commit intoBukimedia:masterfrom
Open
Create of a Credentials class in order to have to authenticate only o…#337joaomfrebelo wants to merge 1 commit intoBukimedia:masterfrom
joaomfrebelo wants to merge 1 commit intoBukimedia:masterfrom
Conversation
…nce. Create of PrestaSharpNotAuthorazedException and PrestaSharpNotFoundException. Create of a FilterFactory class to facilitate the use of GetByFilter. Create of two method in Functins class to clean strings as in Prestashop Validate:isCatalogName($name) and Validate:isGenericName($name)
Collaborator
|
Hello @joaomfrebelo, thanks for the PR! Do you think you could separate the atomic functionalities in separated PRs? It would be better to review. Also, with latest changes in master, GenericFactory.cs has conflicts, can you take a look? |
Collaborator
|
I know it's a bit late but do u think u can finalize this PR? Benjamin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nce.
Create of PrestaSharpNotAuthorazedException and PrestaSharpNotFoundException.
Create of a FilterFactory class to facilitate the use of GetByFilter.
Create of two method in Functins class to clean strings as in Prestashop Validate:isCatalogName($name) and Validate:isGenericName($name)