Fix custom block count/value/limit placeholders for Oraxen, Nexo, ItemsAdder #391#400
Merged
tastybento merged 1 commit intodevelopfrom Feb 20, 2026
Merged
Conversation
- getObjectFromConfigKey: return configKey as-is for unresolved keys instead of only returning when ItemsAdder confirms it; custom block strings (oraxen:x, nexo:x, namespace:id) are stored as String keys in mdCount/uwCount so they must be returned as strings - getItemIdentifier: add Oraxen (OraxenHook.getNamespacedId) and Nexo (NexoItems.idFromItem) checks for _island_count_mainhand - getBlockIdentifier: add Oraxen (OraxenHook.getOraxenBlockID), Nexo (NexoBlocks.customBlockMechanic), and ItemsAdder (ItemsAdderHook.getInCustomRegion) checks for _island_count_looking Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes placeholder support for custom blocks (Oraxen, Nexo, ItemsAdder) in
PlaceholderManager.getObjectFromConfigKey: Previously only returned a custom block's string key when ItemsAdder confirmed it was in its registry — Oraxen and Nexo keys always returnednull, making_island_count_<block>always "0". Fixed by returningconfigKeyas-is for anything that isn't a vanillaMaterialorEntityTypespawner, since custom block strings are stored directly asStringkeys inmdCount/uwCount.getItemIdentifier: Added Oraxen (OraxenHook.getNamespacedId) and Nexo (NexoItems.idFromItem) lookups so_island_count_mainhandcorrectly identifies custom items held in hand.getBlockIdentifier: Added Oraxen (OraxenHook.getOraxenBlockID), Nexo (NexoBlocks.customBlockMechanic), and ItemsAdder (ItemsAdderHook.getInCustomRegion) lookups so_island_count_lookingcorrectly identifies custom blocks being looked at.Test plan
_island_count_<block>placeholder returns the correct count_island_count_mainhandreturns the correct count_island_count_lookingreturns the correct count🤖 Generated with Claude Code