Skip to content

fix missing prefix V1 on sio event Bridge#3

Closed
jooncheol wants to merge 1 commit intoAutoDRIVE-Ecosystem:mainfrom
jooncheol:bugfix
Closed

fix missing prefix V1 on sio event Bridge#3
jooncheol wants to merge 1 commit intoAutoDRIVE-Ecosystem:mainfrom
jooncheol:bugfix

Conversation

@jooncheol
Copy link

The previous code made abnormal behavior of Simulator.

If you check the Socket Client Code in the Simulator, there are 2 lines that expect to parse "Reset" with "V1". But the Devkit's Server side SIO handler emits (send) the custom event "Bridge" with "Reset" without "V1 " prefix.

These are the link of simulator side sio code that were affected from the original devkit code.

After this patch, the simulator didn't have any abnormal behavior on my environment. (Simulator on macOS, devkit on arm64 VM)

@Tinker-Twins
Copy link
Member

The Reset command is currently being handled without a Vehicle ID (e.g., V1) for the RoboRacer Sim Racing Leagues. The AutoDRIVE Simulator has the Vehicle ID associated with the Reset command for other vehicles and multi-agent configurations. Closing this PR for now, please feel free to modify the Socket.cs script in your clone to achieve the desired behavior. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants