Skip to content

Conversation

@rickyrombo
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2026

⚠️ No Changeset found

Latest commit: 3211625

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

})

const trackUploadProgress = useSelector(getCombinedUploadPercentage)
// NOTE: We've observed a bug where the upload saga stalls out sometimes. The user gets stuck at 100% in this case
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

splPath
],
resolver: {
nodeModulesPaths: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting, what was happening before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some "missing deps" errors when running locally, at least for me


const UploadContext = createContext<UploadContextType | null>(null)

export const UploadProvider = ({ children }: { children: ReactNode }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason for making this a context? I don't see anything wrong w/ it, but feels unnecessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed a way for both screens to be able to share the same hook instance, but didn't see a straightforward way to pass them custom props... Let AI take a rip at it 🤷

@rickyrombo rickyrombo merged commit 2464a05 into mjp-tus-upload Jan 27, 2026
10 of 12 checks passed
@rickyrombo rickyrombo deleted the mjp-tus-mobile branch January 27, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants