-
Notifications
You must be signed in to change notification settings - Fork 126
TUS: Mobile #13619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUS: Mobile #13619
Conversation
|
| }) | ||
|
|
||
| const trackUploadProgress = useSelector(getCombinedUploadPercentage) | ||
| // NOTE: We've observed a bug where the upload saga stalls out sometimes. The user gets stuck at 100% in this case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
| splPath | ||
| ], | ||
| resolver: { | ||
| nodeModulesPaths: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh interesting, what was happening before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some "missing deps" errors when running locally, at least for me
|
|
||
| const UploadContext = createContext<UploadContextType | null>(null) | ||
|
|
||
| export const UploadProvider = ({ children }: { children: ReactNode }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason for making this a context? I don't see anything wrong w/ it, but feels unnecessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed a way for both screens to be able to share the same hook instance, but didn't see a straightforward way to pass them custom props... Let AI take a rip at it 🤷
Co-authored-by: Ray Jacobson <[email protected]>
No description provided.