Open
Conversation
Contributor
Author
|
🧪 Testing To try out this version of the SDK, run: Expires at: Thu, 05 Mar 2026 18:05:24 GMT |
5c1cc39 to
58ae94c
Compare
58ae94c to
c150b75
Compare
c150b75 to
84b61ea
Compare
84b61ea to
ed482f7
Compare
ed482f7 to
a65acff
Compare
a65acff to
c64db19
Compare
c64db19 to
a528c2e
Compare
a528c2e to
cea2663
Compare
cea2663 to
68ef000
Compare
68ef000 to
2bcba5c
Compare
2bcba5c to
791c052
Compare
791c052 to
e665f37
Compare
e665f37 to
700ea30
Compare
555a8fa to
e215e30
Compare
e215e30 to
f941f34
Compare
f941f34 to
f1e1a33
Compare
f1e1a33 to
cacf33d
Compare
cacf33d to
50127f7
Compare
50127f7 to
25cea14
Compare
25cea14 to
c272150
Compare
c272150 to
ad26265
Compare
ad26265 to
0987a74
Compare
0987a74 to
3b502ed
Compare
3b502ed to
e92ac9c
Compare
e92ac9c to
4009887
Compare
4009887 to
11e1837
Compare
11e1837 to
2455a1a
Compare
byrro
reviewed
Feb 9, 2026
| """ | ||
| return SecretsResourceWithStreamingResponse(self) | ||
|
|
||
| def create( |
Member
There was a problem hiding this comment.
Would it be possible to name this method create_or_update? Only create may give the impression that it would fail if the secret already exists, which won't be the behavior. Although the docstring says "Create or update", I think the method name is important to communicate the expected behavior as well.
Member
There was a problem hiding this comment.
yup upsert or create_or_update would make much more sense than create. I took a look at the Engine code and it calls this upsert, so I'm not really sure why stainless is generating this as create.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Release PR
1.11.0 (2026-02-03)
Full Changelog: v1.10.0...v1.11.0
Features
Bug Fixes
model_dumpandmodel_dump_jsonfor Pydantic v1 (d4527cf)Chores
actions/github-script(48d3629)--fixargument to lint script (461ab0b)actions/checkoutversion (e003383)Documentation
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions