[PWGEM/Dilepton] update matchingMFT.cxx for dxdy at MP #14522
+57
−29
Merged
Annotations
9 errors and 2 notices
|
Run tests
Process completed with exit code 1.
|
|
Run tests
Issues have been found.
|
|
Run tests:
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L59
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
Run tests:
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
Run tests:
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L1
Specify task name only when it cannot be derived from the struct name. Only append to the default name.
|
|
Run tests:
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L966
Device names matching-mft and matching-m-f-t generated from the specified task name matching-mft and from the struct name matchingMFT, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to MatchingMft and removing TaskName.
|
|
Run tests:
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L400
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
Run tests:
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L257
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
Run tests:
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L400
Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
|
|
Run tests
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
Run tests
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|
Loading