[OCTRL-1044] Demonstrate that standalone Readout can run in a container#753
Merged
justonedev1 merged 1 commit intomasterfrom Oct 15, 2025
Merged
[OCTRL-1044] Demonstrate that standalone Readout can run in a container#753justonedev1 merged 1 commit intomasterfrom
justonedev1 merged 1 commit intomasterfrom
Conversation
25ce337 to
3c66ca5
Compare
knopers8
previously approved these changes
Oct 13, 2025
Collaborator
knopers8
left a comment
There was a problem hiding this comment.
Thanks!
I must admit I don't always like how AI polished the text (randomly bolded text, use of quotation blocks not for quotes), but it's just a taste thing. I'm happy with the results!
docs/running_docker.md
Outdated
|
|
||
| > ⚠️ **Warning** | ||
| > This method is **not intended for production use**. | ||
| > It serves only as a **proof of concept (POC)** for testing Docker images as part of an existing pipeline. |
Collaborator
There was a problem hiding this comment.
Suggested change
| > It serves only as a **proof of concept (POC)** for testing Docker images as part of an existing pipeline. | |
| > It serves only as a **proof of concept** for testing Docker images as part of an existing pipeline. |
Since you're not using the abbreviation later, there is no point in introducing it.
docs/running_docker.md
Outdated
| At the time of writing, Docker must be installed **manually**. | ||
|
|
||
| > ⚠️ **Security Note** | ||
| > The `flp` user must be able to run `sudo` **without a password**, because Docker requires root privileges. |
Collaborator
There was a problem hiding this comment.
Suggested change
| > The `flp` user must be able to run `sudo` **without a password**, because Docker requires root privileges. | |
| > The `flp` user must be able to run `sudo` **without a password**, because Docker requires root privileges. | |
| > Alternatively, set up docker in rootless mode, this was not tested though. |
e3d7670 to
3c6ccc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added description how to run task inside a docker container