Fix handling image attachments and animated images in current conversation#162
Open
winstona wants to merge 3 commits intoAlex-Rose:masterfrom
Open
Fix handling image attachments and animated images in current conversation#162winstona wants to merge 3 commits intoAlex-Rose:masterfrom
winstona wants to merge 3 commits intoAlex-Rose:masterfrom
Conversation
show sent stickers in live view properly with link
|
Using your fork, images seem to only show the preview rather than the actual image. I couldn't get images to show using the original master branch, so at least it's a step in the right direction, thanks :) |
This was referenced May 28, 2019
|
The problem this PR addresses is still an ongoing issue. I feel like getting images to show is more important, and the preview problem can be solved in a separate PR as there was a separate issue opened for it. #157 This PR does not address other file types though (video, audio, file still show up as blank message), even though theoretically the handling principle should be the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image attachments and animated images would fail to show any message indication when conversation is open despite successfully showing when the conversation is refreshed/reopened.
This adds extra filters for these message types