Conversation
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
===========================================
- Coverage 100.00% 95.91% -4.09%
===========================================
Files 17 19 +2
Lines 704 734 +30
===========================================
Hits 704 704
- Misses 0 30 +30
|
someshsingh22
left a comment
There was a problem hiding this comment.
@arihantbansal you have not added the callbacks, the logger needs to have that as well
someshsingh22
left a comment
There was a problem hiding this comment.
This looks extensive and great! However, since this is in the debug mode it is not being tested, If you can add an example to show the behavior of all Loggers
|
@arihantbansal Can you try implementing your logger in the GAN Tutorial notebook so we can merge it ? |
|
@arihantbansal can you write the tests to complete the PR, Tensorboard and Tutorial test can be integrated in a different PR |
I'll try fix the callback logging and implement it in the tutorial by EOD. |
Remove logger from testing
This PR resolves Issue #23.