Attempt at reducing the possibility of having import cycles when user configs import rez#1918
Draft
JeanChristopheMorinPerso wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
JeanChristopheMorinPerso
force-pushed
the
reduce_import_sycles_from_config
branch
2 times, most recently
from
8cbf219 to
9dc285d
Compare
… configs import rez Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
force-pushed
the
reduce_import_sycles_from_config
branch
from
9dc285d to
d1b9a45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1904
Attempt at reducing the possibility of having import cycles when user configs import rez.
A simple user config that simply imported
rez.package_orderwould fail due to circular imports.This is a big issue with rez where we already have to do a lot of local imports...
Anyway, this PR is just an experiment. It does remove the likelihood of cycles.
Another approach we could use could be something like https://rez.readthedocs.io/en/stable/configuring_rez.html#delay-load but instead of accepting a path, it could accept a function. That function could be safely called after the config is loaded. Not too sure how it would work or if it would even work.
From my analysis,
rez.serialisewas the most problematic. It's a core module that gets imported in multiple places. It should very much avoid importing modules likerez.config. In an ideal world, none of our "utilities" module should importrez.config.