Skip to content

feat: add more shader group diagnostics to compile_report #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgritz merged 2 commits into from
Mar 5, 2026
Merged

feat: add more shader group diagnostics to compile_report #2085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76972af
feat: add more shader group diagnostics to compile_report
lgritz Feb 26, 2026
7e4550d
amendment: also count the number of noise calls
lgritz Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 38 additions & 4 deletions src/liboslexec/runtimeoptimize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3278,11 +3278,15 @@ RuntimeOptimizer::run()
m_userdata_needed.clear();
m_attributes_needed.clear();
bool does_nothing = true;
int active_layers = 0;
int n_texture_ops = 0;
int n_noise_ops = 0;
std::vector<uint8_t> interactive_data;
for (int layer = 0; layer < nlayers; ++layer) {
set_inst(layer);
if (inst()->unused())
continue; // no need to print or gather stats for unused layers
++active_layers;
FOREACH_SYM(Symbol & s, inst())
{
// set the layer numbers
Expand Down Expand Up @@ -3355,6 +3359,7 @@ RuntimeOptimizer::run()
}
}
if (opd->flags & OpDescriptor::Tex) {
++n_texture_ops;
// for all the texture ops, arg 1 is the texture name
Symbol* sym = opargsym(op, 1);
OSL_DASSERT(sym && sym->typespec().is_string());
Expand All @@ -3364,6 +3369,13 @@ RuntimeOptimizer::run()
m_unknown_textures_needed = true;
}
}
if (op.opname() == Strings::noise || op.opname() == Strings::snoise
|| op.opname() == Strings::pnoise
|| op.opname() == Strings::psnoise
|| op.opname() == Strings::cellnoise
|| op.opname() == Strings::hashnoise) {
++n_noise_ops;
}
if (op.opname() == u_closure) {
// It's either 'closure result weight name' or 'closure result name'
Symbol* sym = opargsym(op, 1); // arg 1 is the closure name
Expand Down Expand Up @@ -3445,6 +3457,23 @@ RuntimeOptimizer::run()
group().does_nothing(does_nothing);
group().setup_interactive_arena(interactive_data);

// Compute the maximum depth of the shader network: the length of the
// longest chain of layer-to-layer connections. Layers are already in
// topological order, so a single forward pass suffices.
std::vector<int> layer_depth(nlayers, 0);
int max_network_depth = 0;
for (int layer = 0; layer < nlayers; ++layer) {
if (group()[layer]->unused())
continue;
layer_depth[layer] = 1;
for (auto&& c : group()[layer]->connections()) {
if (!group()[c.srclayer]->unused())
layer_depth[layer] = std::max(layer_depth[layer],
layer_depth[c.srclayer] + 1);
}
max_network_depth = std::max(max_network_depth, layer_depth[layer]);
}

m_stat_specialization_time = rop_timer();
{
// adjust memory stats
Expand All @@ -3468,26 +3497,31 @@ RuntimeOptimizer::run()
new_nops, old_nops,
100.0 * double((long long)new_nops - (long long)old_nops)
/ double(old_nops));
shadingcontext()->infofmt(" Group active layers: {}", active_layers);
shadingcontext()->infofmt(" Group network connection depth: {}",
max_network_depth);
shadingcontext()->infofmt(" Group texture ops: {}", n_texture_ops);
shadingcontext()->infofmt(" Group noise ops: {}", n_noise_ops);
}
if (shadingsys().m_compile_report > 1) {
if (does_nothing)
shadingcontext()->infofmt("Group does nothing");
shadingcontext()->infofmt(" Group does nothing");
if (m_textures_needed.size()) {
shadingcontext()->infofmt("Group needs textures:");
shadingcontext()->infofmt(" Group needs textures:");
for (auto&& f : m_textures_needed)
shadingcontext()->infofmt(" {}", f);
if (m_unknown_textures_needed)
shadingcontext()->infofmt(
" Also may construct texture names on the fly.");
}
if (m_userdata_needed.size()) {
shadingcontext()->infofmt("Group potentially needs userdata:");
shadingcontext()->infofmt(" Group potentially needs userdata:");
for (auto&& f : m_userdata_needed)
shadingcontext()->infofmt(" {} {} {}", f.name, f.type,
f.derivs ? "(derivs)" : "");
}
if (m_attributes_needed.size()) {
shadingcontext()->infofmt("Group needs attributes:");
shadingcontext()->infofmt(" Group needs attributes:");
for (auto&& f : m_attributes_needed)
shadingcontext()->infofmt(" {} {} {}", f.name, f.scope,
f.type);
Expand Down
Loading