🔒 Security Fix: Remove insecure 'Ignore SSL Errors' option #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical security vulnerability by removing the "Ignore SSL Errors" feature.
Previously, the app allowed users to disable SSL certificate validation, which could be exploited to intercept secure traffic.
Changes:
TrustManagerandHostnameVerifierlogic. TheOkHttpClientnow uses the system's default secure configuration.ignoreSslErrorsproperty and storage key.SSLContextbased on the preference.LibraryDrawerContent.kt) and the corresponding state inLibraryViewModel.kt.CloudflareDialogto rely on standard WebView SSL handling (which blocks invalid certs by default).LibraryViewModelTest.ktto ensure the ViewModel remains stable after removing the dependency. Validated with existing unit tests.Risk Assessment:
PR created automatically by Jules for task 860067918690827876 started by @Aatricks