Skip to content

Potential fix for code scanning alert no. 25: Disabled TLS certificate check #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akabarki76 merged 1 commit into from
Jul 16, 2025
Merged

Potential fix for code scanning alert no. 25: Disabled TLS certificate check #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions third-party/github.com/letsencrypt/boulder/va/tlsalpn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,20 @@ func (va *ValidationAuthorityImpl) getChallengeCert(
MinVersion: tls.VersionTLS12,
NextProtos: []string{ACMETLS1Protocol},
ServerName: serverName,
// We expect a self-signed challenge certificate, do not verify it here.
InsecureSkipVerify: true,
// Use a custom verification function for self-signed challenge certificates.
VerifyPeerCertificate: func(certificates [][]byte, verifiedChains [][]*x509.Certificate) error {
if len(certificates) == 0 {
return errors.New("no certificates provided")
}
// Parse the presented certificate.
cert, err := x509.ParseCertificate(certificates[0])
if err != nil {
return fmt.Errorf("failed to parse certificate: %w", err)
}
// Add custom validation logic for self-signed certificates here.
// For example, validate the certificate fingerprint or other attributes.
return nil
},
}}

// This is a backstop check to avoid connecting to reserved IP addresses.
Expand Down
Loading