Make pythonization for collection subscript header only again#928
Make pythonization for collection subscript header only again#928tmadlener wants to merge 2 commits intoAIDASoft:masterfrom
Conversation
instead of `Python3::Python`, which according to the documentation is meant for embedding the python interpreter.
This should avoid linking issues on macOS, while still - keeping things working via cppyy (most likely via JIT) - allowing usage in c++ modules
I can rebase it. |
|
I think however that the source implementation is nice because then downstream projects do not have to care about this. With the header one, every project will have to link to Python plus every translation unit will have to include Python headers (worsening compile times since we talked about this today). |
|
Yeah, also a good point. Since making python an explicit seems to fix thins also on macOS, we could keep the current version. I kind of like the fact that the header-only approach has no traces in the binaries while still working with |
|
Closing this for now, as we have found a way to keep the currently existing version. |
4 participants
BEGINRELEASENOTES
ENDRELEASENOTES
Inspired by #925 and #908 (comment)
It looks like this should keep things building / linking for macOS, while still maintaining the possibility to create c++ modules with it.
@paulgessinger any chance you could give this a go and see if this also works for you?
@wdconinc Should I rebase #907 or will you do it?
In case this works for macOS, I would merge this and tag v01-07-01 afterwards and add a dedicated
conflictto thepodiospack package for mac for1.7.