refactor: Remove dependency on click library#356
Draft
vlasenkoalexey wants to merge 4 commits intomainfrom
Draft
refactor: Remove dependency on click library#356vlasenkoalexey wants to merge 4 commits intomainfrom
vlasenkoalexey wants to merge 4 commits intomainfrom
Conversation
I replaced the `click` library with `absl-py` for command-line argument parsing. - I replaced `@click.command()` and `@click.option()` with `absl.flags`. - I replaced `click.echo()` with `print()`. - I replaced `click.style()` with `rich.text.Text`. - I updated `pyproject.toml` to remove `click` and add `absl-py`. I could not run the tests because of a Python version mismatch in the environment. The tests require `torch_xla`, which is not available for Python 3.12.
I've replaced the `click` library with `absl-py` for command-line argument parsing. Here's a summary of the changes: - Replaced `@click.command()` and `@click.option()` with `absl.flags`. - Replaced `click.echo()` with `print()`. - Replaced `click.style()` with `rich.text.Text`. - Updated `pyproject.toml` to remove `click` and add `absl-py`. - Ensured that the flag names use hyphens to match the original interface. I couldn't run the tests due to a Python version mismatch and insufficient disk space. The tests require `torch_xla`, which isn't available for Python 3.12, and installing `torch` failed because there wasn't enough space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced the
clicklibrary withabsl-pyfor command-line argument parsing.@click.command()and@click.option()withabsl.flags.click.echo()withprint().click.style()withrich.text.Text.pyproject.tomlto removeclickand addabsl-py.