feat: Support iframe rendering

[shaohuzhang1]

feat: Support iframe rendering

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code template has some potential areas for improvement in terms of security, readability, and performance. Here are my suggestions:

Security Improvements

1. Content Security Policy (CSP):
   • Ensure that the sandbox attributes include necessary CSP directives like 'content-security-policy': "default-src 'self';" to prevent XSS attacks.

@sandbox="'allow-scripts' 'allow-same-origin'" + (
  !props.script_exec ? '; object-src \'none\'' : ''
)

2. Frame-Busting Protection:
   • Add basic frame-busting protection by checking against common anti-framebuster methods.

@if (iframes && Array.isArray(iframes)) {
  <script>
    try {
      document.top.location.href = window.self.location.toString();
    } catch (e) {}
  </script>
}

3. Script Execution Control:
   • If you intend to allow scripts programmatically, ensure they're trusted sources or sanitize them before adding them manually.

Readability and Style Optimization

1. Inline Styles in CSS:
   • Consider moving the styles inline rather than defining them globally in a separate style block. This can make the component more self-contained.

<style scoped>
.iframe-wrapper {
  width: 100%;
  height: 100%;
}

.iframe {
  width: 100%;
  height: 100%;
  border: none;
}
</style>

2. Variable Naming Consistency:

   • Use consistent naming conventions. For example, resize, finalSource, iframe, etc., should be clear and descriptive.

3. Whitespace Reduction:

   • Remove unnecessary spaces around operators and braces to improve legibility.

Performance Improvements

1. Async/Await Best Practices:
   • Use await without wrapping promises in parentheses when not needed.

async function resize() {
  await nextTick()

  const iframe = iframeRef.value
  if (!iframe) return

  // ...
}

2. Conditional Rendering Optimization:
   • Avoid unnecessarily re-running watch functions each time props change. Instead, optimize based on prop changes directly.

watch(
  () => props.visible,
  (newVisible) => {
    if (newVisible && iframeRef.value) {
      iframeRef.value.srcdoc = finalSource.value
    }
  },
)

By implementing these improvements, you can enhance the robustness, security, and efficiency of your Vue.js component using Vue Composition API.

Security Note: Always consider the security implications of your implementation when handling external data, especially if it involves executing scripts or allowing arbitrary content loading (<source>).