Skip to content

lisovo: CLZ opcode and P256 gas cost changes#2040

Merged
kamuikatsurgi merged 10 commits intodevelopfrom
kamui/tbd-hf-changes
Feb 5, 2026
Merged

lisovo: CLZ opcode and P256 gas cost changes#2040
kamuikatsurgi merged 10 commits intodevelopfrom
kamui/tbd-hf-changes

Conversation

@kamuikatsurgi
Copy link
Member

Description

Introduces TBDHF to support CLZ opcode and P256 gas cost changes.

@claude
Copy link

claude bot commented Feb 4, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 77.55102% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.59%. Comparing base (a311f8c) to head (add7981).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
core/vm/jump_table_export.go 0.00% 6 Missing ⚠️
params/config.go 57.14% 3 Missing ⚠️
core/vm/evm.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (77.55%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2040      +/-   ##
===========================================
+ Coverage    49.57%   49.59%   +0.01%     
===========================================
  Files          873      873              
  Lines       150507   150537      +30     
===========================================
+ Hits         74615    74653      +38     
+ Misses       70860    70848      -12     
- Partials      5032     5036       +4     
Files with missing lines Coverage Δ
consensus/misc/eip1559/eip1559.go 97.34% <100.00%> (+3.17%) ⬆️
core/vm/contracts.go 75.49% <100.00%> (+0.55%) ⬆️
core/vm/jump_table.go 99.59% <100.00%> (+<0.01%) ⬆️
internal/cli/server/config.go 61.69% <ø> (ø)
internal/cli/server/flags.go 100.00% <100.00%> (ø)
params/protocol_params.go 84.21% <100.00%> (ø)
core/vm/evm.go 27.33% <0.00%> (-0.07%) ⬇️
params/config.go 31.91% <57.14%> (-0.35%) ⬇️
core/vm/jump_table_export.go 0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

Files with missing lines Coverage Δ
consensus/misc/eip1559/eip1559.go 97.34% <100.00%> (+3.17%) ⬆️
core/vm/contracts.go 75.49% <100.00%> (+0.55%) ⬆️
core/vm/jump_table.go 99.59% <100.00%> (+<0.01%) ⬆️
internal/cli/server/config.go 61.69% <ø> (ø)
internal/cli/server/flags.go 100.00% <100.00%> (ø)
params/protocol_params.go 84.21% <100.00%> (ø)
core/vm/evm.go 27.33% <0.00%> (-0.07%) ⬇️
params/config.go 31.91% <57.14%> (-0.35%) ⬇️
core/vm/jump_table_export.go 0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucca30
Copy link
Contributor

lucca30 commented Feb 4, 2026

I'm going to ask to hold this PR until I merge mine into this one. So we introduce both changes in a single merge to develop

@kamuikatsurgi kamuikatsurgi changed the title tbdhf: CLZ opcode and P256 gas cost changes lisovo: CLZ opcode and P256 gas cost changes Feb 4, 2026
@lucca30
Copy link
Contributor

lucca30 commented Feb 5, 2026

Here's the HF #2041

lucca30 and others added 2 commits February 5, 2026 13:20
* covering super low fee scenario

* moving configurable rules to lisovo

* fix missing tests
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

@kamuikatsurgi kamuikatsurgi merged commit 7cebf18 into develop Feb 5, 2026
25 of 29 checks passed
@kamuikatsurgi kamuikatsurgi deleted the kamui/tbd-hf-changes branch February 5, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants