-
Notifications
You must be signed in to change notification settings - Fork 2
Description
Problem
In the Igneous task creation, specifically in the downsample_for_meshing and downsample methods, we've observed that downsampling tasks are skipped if the input data is already isotropic (if mip == target_mip:).
Impact
The issue arises when we want to process isotropic inputs through the downsampling pipeline, for purposes beyond merely making the data isotropic. The current code doesn't allow us to do so because the conditions check for isotropic data and skip the downsampling process altogether.
Proposed Solution
We propose a modification to the conditions in the mentioned methods so that downsampling tasks aren't automatically skipped for isotropic data. Providing an option or a flag to choose whether to skip isotropic inputs could be a possible solution.
We suggest something like:
def downsample_for_meshing(run_name, seg_cloudpath, mask, skip_isotropic=True):
...
if skip_isotropic and mip == target_mip:
...
And similar for the downsample function.
Benefits
This modification will provide users with greater flexibility in managing their data processing pipeline, enabling them to pass isotropic data through the downsampling process if needed.
Looking forward to your thoughts on this.