Fix

Author: choldgraf

.github/workflows/tests.yaml

@@ -33,7 +33,10 @@ jobs:
     runs-on: ubuntu-24.04
     env:
       # This is a private access token for @choldgraf that has public read-only access.
-      GHA_ACCESS_TOKEN: "${{ secrets.TOKEN_READONLY }}"
+      # WARNING: This only works for PRs from non-forked repositories.
+      #   FUTURE: We should update the tests to only pull from this repository and not
+      #           need a token at all.
+      GITHUB_ACCESS_TOKEN: "${{ secrets.TOKEN_READONLY }}"
     strategy:
       matrix:
         include:

github_activity/github_activity.py

@@ -170,16 +170,16 @@ def get_activity(
         search_query = f"user:{org}"
 
     if auth is None:
-        for kind in ["GITHUB_ACCESS_TOKEN", "GHA_ACCESS_TOKEN"]:
-            if kind in os.environ:
+        for authkey in ["GITHUB_ACCESS_TOKEN", "GHA_ACCESS_TOKEN"]:
+            if authkey in os.environ:
                 # Access token is stored in a local environment variable so just use this
                 print(
-                    f"Using GH access token stored in `{kind}`.",
+                    f"Using GH access token stored in `{authkey}`.",
                     file=sys.stderr,
                 )
-                auth = os.environ.get(kind)
+                auth = os.environ.get(authkey)
                 if auth == "":
-                    raise ValueError(f"Found {kind}, but it is empty...")
+                    raise ValueError(f"Found {authkey}, but it is empty...")
 
     if auth is None:
         # Attempt to use the gh cli if installed
@@ -220,7 +220,7 @@ def get_activity(
     if kind:
         allowed_kinds = ["issue", "pr"]
         if kind not in allowed_kinds:
-            raise ValueError(f"Kind must be one of {allowed_kinds}")
+            raise ValueError(f"Kind must be one of {allowed_kinds}, got {kind}")
         search_query += f" type:{kind}"
 
     # Query for both opened and closed issues/PRs in this window