IOS only, Override of a default method generates uncompilable code

[ddyer0]

The base method in an interface is this:

      public default void drawNumber(Graphics gc,PlacementProvider source,PlacementProvider dest,int cellSize,int x,int y,Font font,Color color, String str)
      {	
    	 ...
      	
      }

The override method is this:

    public void drawNumber(Graphics gc,PlacementProvider source,PlacementProvider dest,int cellSize,int x,int y,Font font,Color color, String str)
    {	
    	TruCell cell = (TruCell)dest;
    	int xx = x-cellSize;
    	int yy = y+cellSize;
    	if(cell.lastFlipped>0) {
    	StockArt.SwingCW.drawChip(gc,this,cellSize,xx,yy,null);
    	}
    	else
    	{
    		super.drawNumber(gc,source,dest,cellSize,xx+cellSize,yy-cellSize,font,color, str);
    	}
    }

the compilation error when built is this:

'virtual_online_game_CCanvas_drawNumber___lib_Graphics_online_game_PlacementProvider_online_game_PlacementProvider_int_int_int_com_codename1_ui_Font_bridge_Color_java_lang_String' declared here
 1314 | JAVA_VOID virtual_online_game_CCanvas_drawNumber___lib_Graphics_online_game_PlacementProvider_online_game_PlacementProvider_int_int_int_com_codename1_ui_Font_bridge_Color_java_lang_String(CODENAME_ONE_THREAD_STATE, JAVA_OBJECT  __cn1ThisObject, JAVA_OBJECT __cn1Arg1, JAVA_OBJECT __cn1Arg2, JAVA_OBJECT __cn1Arg3, JAVA_INT __cn1Arg4, JAVA_INT __cn1Arg5, JAVA_INT __cn1Arg6, JAVA_OBJECT __cn1Arg7, JAVA_OBJECT __cn1Arg8, JAVA_OBJECT __cn1Arg9);
      |           ^
1 error generated.

[ddyer0]

Here is a test program. The structure mirrors the actual structure of the problem I encoutered. It doesn't matter
what this program does - the point is that it doesn't build on IOS.

/**
 * demo program for  issue 4401, fontmetric cache failure
*/
package com.boardspace.dtest;

import com.codename1.ui.Component;
// 
// drawing pdfs
//
//
import com.codename1.ui.Display;
import com.codename1.ui.Form;
import com.codename1.ui.Graphics;
import com.codename1.ui.Toolbar;
import com.codename1.ui.geom.Dimension;
import com.codename1.ui.plaf.UIManager;
import com.codename1.ui.util.Resources;

import java.util.ArrayList;

/*
Copyright 2006-2023 by Dave Dyer

This file is part of the Boardspace project.

Boardspace is free software: you can redistribute it and/or modify it under the terms of 
the GNU General Public License as published by the Free Software Foundation, 
either version 3 of the License, or (at your option) any later version.

Boardspace is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;
without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. 
See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with Boardspace.
If not, see https://www.gnu.org/licenses/.
*/

import java.util.Hashtable;

import com.codename1.ui.Font;

import com.codename1.ui.geom.Rectangle2D;

interface Drawable {
	
}
interface PlacementProvider
{	
	int getLastPlacement(boolean empty);
}

interface NumberMenuHost {


      public default void drawNumber(Graphics gc,PlacementProvider source,PlacementProvider dest,int cellSize,int x,int y,Font font,Color color, String str)
      {	
    	  System.out.println("drawnumber "+source);
      	
      }

      public default void drawNumber(Graphics gc,PlacementProvider source,PlacementProvider dest,int cellSize,int x,int y,Font font,Color color, Drawable str)
      {	
    	  System.out.println("drawNumber "+x);
      }


      public default void drawArrow(Graphics gc,PlacementProvider src,PlacementProvider dest,
    		  int x1,int y1,int x2,int y2,
    		  Color color,double arrowOpacity,
    		  int ticksize,double linew)
      { System.out.println("drawarrow "+x1);
      }
      
      public default int getLastPlacement() {
			throw new Error("getLastPlacement must be overriden");
		}

}

class Color {
	int r;int g;int b;
}

class FontMetrics {


private Font myFont;
static Hashtable <Font,FontMetrics>fmCache  = new Hashtable<Font,FontMetrics>();

public FontMetrics(Font f) 
	{ myFont = f;
	  int oldsize = fmCache.size();
	  FontMetrics old = fmCache.get(f);
	  fmCache.put(f,this); 
	  int newsize = fmCache.size();
	  Test.messages.add("add font "+f+" was "+old+" "+oldsize);
	  Test.messages.add("new "+this+newsize);

	}
public static FontMetrics getFontMetrics(Font g) 
{	
	FontMetrics m = fmCache.get(g);
	if(m==null) 
		{	
			m = new FontMetrics(g);
		}
	if(m.myFont!=g)
	{
		Test.messages.add("Impossible mismatch fm "+m+" "+m.myFont+" "+g);
		FontMetrics m2 = fmCache.get(m.myFont);
		Test.messages.add("Other is "+m2);
		m = new FontMetrics(g);
	}
	return m;
}
public int getMaxDescent() { return myFont.getDescent(); }

public static FontMetrics getFontMetrics(Graphics g) 
{ 	return(getFontMetrics(g.getFont())); 
}


public Font getFont() { return(myFont); }


public int getHeight() 
{	
	int h = myFont.getHeight(); 
	return h;
}
public int getDescent() { return(myFont.getDescent()); }
public int getAscent() { return(myFont.getAscent()); }
public int getMaxAscent() 
	{ // the standard spec is a little fuzzy, it says
	  // "ascent" is the height for most alphanumeric characters,
	  // but some characters may be taller.  So we hope getAscent is 
	  // good enough
		return(myFont.getAscent());	
	}

public static  Font getFont(Font f,int size)
{	
	Font fd = f.derive(size,0);
	return(fd);
}
static int fontFaceCode(String spec)
{
	   if ("monospaced".equalsIgnoreCase(spec)) { return Font.FACE_MONOSPACE; }
	   if ("serif".equalsIgnoreCase(spec)) { return Font.FACE_PROPORTIONAL; }
	   return Font.FACE_SYSTEM;
}

public static Font getFont(String family,int size)
{	
	Font f = Font.createSystemFont(fontFaceCode(family),0,size);
	return f;
}
}

class NumberHost extends Component implements NumberMenuHost
{
	
}
class Test extends NumberHost implements Runnable,NumberMenuHost
{	Form form = null;
	static ArrayList<String>messages = new ArrayList<String>();
	static void Message(String m) { messages.add(m); }
    public void drawNumber(Graphics gc,PlacementProvider source,PlacementProvider dest,int cellSize,int x,int y,Font font,Color color, String str)
    {	
    	PlacementProvider cell = dest;
    	int xx = x-cellSize;
    	int yy = y+cellSize;
    	if(xx>yy) {
    	 System.out.println("draw "+cell);
    	}
    	else
    	{
    		super.drawNumber(gc,source,dest,cellSize,xx+cellSize,yy-cellSize,font,color, str);
    	}
    }
	public Component getCanvas() { return this; }
	Test(Form f)
	{	form = f;
		setPreferredSize(new Dimension(f.getWidth(),f.getHeight()));
	}
	int loops = 0;
	int phase = 0;
	String got = "first with coords";
	String got2 = "second with rectangle";	
	public void paint(Graphics gc)
	{	
		int w = form.getWidth();
		int h = form.getHeight();
		int step = 40;
		gc.setColor(0x806060);
		gc.fillRect(0,0,w,h);
		gc.setColor(0);
		String phase = "before";
		try {
			for(int i=0;i<messages.size() && i*step<h;i++ )
			{
				gc.drawString(messages.get(i),20,(i+1)*step);
			}
		}
		catch(Throwable err)
		{
			gc.drawString("error "+err+" in phase "+phase,100,400);
		}
	}
	public void run() {
		int sz = 10;
		Font f = FontMetrics.getFont("Arial Unicode MS",sz);
		for(int i=0;i<10;i++)
		{
			FontMetrics.getFontMetrics(f);
			Font f1 = FontMetrics.getFont(f,sz++);
			FontMetrics.getFontMetrics(f1);
		}

		while(true)
			{ this.repaint();
			  try { Thread.sleep(1000); }
			  catch(InterruptedException e) {}

			}
	}
}
@SuppressWarnings("rawtypes")
public class Dtest{

private Form current;
@SuppressWarnings("unused")
private Resources theme;



public void init(Object context) {
    theme = UIManager.initFirstTheme("/theme");
    // Pro only feature, uncomment if you have a pro subscription
    // Log.bindCrashProtection(true);
    

}
public Toolbar toolbar = null;


public void run()
{
    

}
public void start() {
    
    if(current != null){
        current.show();
    }
    Form hi = new Form();
    hi.setToolbar(new Toolbar());
    Test can = new Test(hi);
    hi.addComponent(can);
    can.setVisible(true);
    new Thread(can).start();
    hi.show();

}
public void stop() {
    current = Display.getInstance().getCurrent();
}

public void destroy() {
}

}

[ddyer0]

Thanks. When will this appear in the build server?

[ddyer0]

As of now, this hasn't appeared in the public build servers yet. I thought that normally happened on Fridays?

[shai-almog]

This was deployed. We pushed two updates to workaround crashes some developers experience. Are you sure it's the same issue?

[ddyer0]

the issue in my build is still there. the test program i supplied still fails to compile.

[shai-almog]

Send a build log with the exact failure. We pushed a 3rd update just now. I want to see if updates are correct.

[ddyer0]

Here's a freshly made error log, from the same test program as above.

error(31).txt

[shai-almog]

Pushed another attempt at fixing this: #4431
Deployment to build servers will take a bit as I'm still investigating another regression.

[shai-almog]

Pushed the update now.

[ddyer0]

my test case compiles now, but the actual case still fails. I'll attach that log

error(3).txt

[shai-almog]

I was able to reproduce this here: #4436