Skip to content

Fuzzy matching won't return multiple exact matches. #129

@cameron-toy

Description

@cameron-toy

@adamperlin @mfekadu

Describe the bug
So first, some good news (in a bug report!): accessing views works fine. I made an SQLAlchemy object to access the Professor/Section view and get_property_from_entity() works as expected.

The bad news is that I'm currently unable to use get_property_from_entity() to answer questions like "What sections does Dr. Khosmood teach?" even with modification.

The current get_property_from_entity() returns the closest match. I made a function _get_property_from_entity() that returns the full list of matches, but if I put in "Irene Humer" as the search term I only get one match, even though she teaches multiple sections.

How to recreate this behavior

See the code of the latest pull request. Run "test_view_access.py"

Expected behavior

print(db._get_property_from_entity(
    "section_name",
    ProfessorSectionView,
    "Irene Humer"
))

[(133, ['Irene ', Humer'], 'CPE 101_01), (133, ['Irene ', Humer'], 'CPE 203_03), (133, ['Irene ', Humer'], 'CPE 203_04), ... etc]

Screenshots
Actual behavior:

Screenshot

Desktop (please complete the following information):

  • OS: macOS 10.15.3

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions