From ae765484f8dbfc3330294714dd1275a35138f82c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Mon, 17 Mar 2025 19:49:09 +0100 Subject: [PATCH 1/6] try installing composite actions --- .github/actions/find-artifact/action.yml | 10 ++++++++-- .github/actions/rnef-native-fingerprint/action.yml | 10 ++++++++-- .github/actions/rnef-native-fingerprint/package.json | 2 +- .github/actions/rnef-post-build/action.yml | 12 +++++++++--- action.yml | 4 ++++ 5 files changed, 30 insertions(+), 8 deletions(-) diff --git a/.github/actions/find-artifact/action.yml b/.github/actions/find-artifact/action.yml index 5169038..07ea23c 100644 --- a/.github/actions/find-artifact/action.yml +++ b/.github/actions/find-artifact/action.yml @@ -25,5 +25,11 @@ outputs: artifact-ids: description: 'All IDs of the artifacts matching the name' runs: - using: 'node20' - main: 'index.js' + using: 'composite' + steps: + - name: Install dependencies + run: npm install + shell: bash + - name: Run find artifact + run: node index.js + shell: bash diff --git a/.github/actions/rnef-native-fingerprint/action.yml b/.github/actions/rnef-native-fingerprint/action.yml index 4c8f39a..fedd910 100644 --- a/.github/actions/rnef-native-fingerprint/action.yml +++ b/.github/actions/rnef-native-fingerprint/action.yml @@ -12,5 +12,11 @@ outputs: hash: description: 'The fingerprint hash' runs: - using: 'node20' - main: 'index.mjs' \ No newline at end of file + using: 'composite' + steps: + - name: Install dependencies + run: npm install + shell: bash + - name: Run fingerprint + run: node index.mjs + shell: bash diff --git a/.github/actions/rnef-native-fingerprint/package.json b/.github/actions/rnef-native-fingerprint/package.json index 4be30e9..54ec520 100644 --- a/.github/actions/rnef-native-fingerprint/package.json +++ b/.github/actions/rnef-native-fingerprint/package.json @@ -2,7 +2,7 @@ "name": "rnef-native-fingerprint", "version": "1.0.0", "description": "Generate native fingerprint for RNEF builds", - "main": "index.js", + "main": "index.mjs", "dependencies": { "@actions/core": "^1.11.1" } diff --git a/.github/actions/rnef-post-build/action.yml b/.github/actions/rnef-post-build/action.yml index 3f6d766..cefb167 100644 --- a/.github/actions/rnef-post-build/action.yml +++ b/.github/actions/rnef-post-build/action.yml @@ -1,5 +1,5 @@ name: 'Post Build' -description: 'Post Build info' +description: 'Post build comment for RNEF builds' inputs: artifact-url: @@ -13,5 +13,11 @@ inputs: required: false default: ${{ github.token }} runs: - using: 'node20' - main: 'index.js' + using: 'composite' + steps: + - name: Install dependencies + run: npm install + shell: bash + - name: Run post build + run: node index.js + shell: bash diff --git a/action.yml b/action.yml index a9aaf85..2ec0b6d 100644 --- a/action.yml +++ b/action.yml @@ -61,6 +61,10 @@ outputs: runs: using: 'composite' steps: + - name: Install dependencies + run: npm install + shell: bash + - name: Validate inputs run: | if [ "${{ inputs.destination }}" != "simulator" ] && [ "${{ inputs.destination }}" != "device" ]; then From f06f5453e4b3e625fc2147c0feb4c4ddb2a0961a Mon Sep 17 00:00:00 2001 From: szymonrybczak Date: Tue, 18 Mar 2025 18:57:35 +0100 Subject: [PATCH 2/6] fix: install properly packages and pass environment variables --- .github/actions/find-artifact/action.yml | 28 ++++++---- .../find-artifact/{index.js => index.mjs} | 51 ++++++++++++------- .../rnef-native-fingerprint/action.yml | 10 +++- .../rnef-native-fingerprint/package.json | 1 + .github/actions/rnef-post-build/action.yml | 12 +++-- .../rnef-post-build/{index.js => index.mjs} | 21 ++++++-- action.yml | 8 +-- package.json | 2 +- 8 files changed, 91 insertions(+), 42 deletions(-) rename .github/actions/find-artifact/{index.js => index.mjs} (68%) rename .github/actions/rnef-post-build/{index.js => index.mjs} (68%) diff --git a/.github/actions/find-artifact/action.yml b/.github/actions/find-artifact/action.yml index 07ea23c..1975e0a 100644 --- a/.github/actions/find-artifact/action.yml +++ b/.github/actions/find-artifact/action.yml @@ -1,8 +1,8 @@ -name: 'Find Artifact' -description: 'Find the latest artifact' +name: "Find Artifact" +description: "Find the latest artifact" inputs: name: - description: 'Artifact name' + description: "Artifact name" required: false re-sign: description: Re-sign the app bundle with new JS bundle @@ -19,17 +19,27 @@ inputs: default: ${{ github.repository }} outputs: artifact-id: - description: 'The ID of the artifact' + description: "The ID of the artifact" + value: ${{ steps.find-artifact.outputs.artifact-id }} artifact-url: - description: 'The URL of the artifact' + description: "The URL of the artifact" + value: ${{ steps.find-artifact.outputs.artifact-url }} artifact-ids: - description: 'All IDs of the artifacts matching the name' + description: "All IDs of the artifacts matching the name" + value: ${{ steps.find-artifact.outputs.artifact-ids }} runs: - using: 'composite' + using: "composite" steps: - name: Install dependencies run: npm install shell: bash - - name: Run find artifact - run: node index.js + working-directory: ${{ github.action_path }} + - name: Find artifact + id: find-artifact + env: + INPUT_NAME: ${{ inputs.name }} + INPUT_RE_SIGN: ${{ inputs.re-sign }} + INPUT_GITHUB_TOKEN: ${{ inputs.github-token }} + INPUT_REPOSITORY: ${{ inputs.repository }} + run: node ${{ github.action_path }}/index.mjs shell: bash diff --git a/.github/actions/find-artifact/index.js b/.github/actions/find-artifact/index.mjs similarity index 68% rename from .github/actions/find-artifact/index.js rename to .github/actions/find-artifact/index.mjs index 331c5ff..84bb9cc 100644 --- a/.github/actions/find-artifact/index.js +++ b/.github/actions/find-artifact/index.mjs @@ -1,5 +1,5 @@ -const core = require('@actions/core'); -const github = require('@actions/github'); +import * as core from "@actions/core"; +import * as github from "@actions/github"; const perPage = 100; // Maximum allowed by GitHub API @@ -9,8 +9,8 @@ async function fetchArtifacts(octokit, repository, name) { while (true) { const response = await octokit.rest.actions.listArtifactsForRepo({ - owner: repository.split('/')[0], - repo: repository.split('/')[1], + owner: repository.split("/")[0], + repo: repository.split("/")[1], name, per_page: perPage, page, @@ -31,7 +31,7 @@ async function fetchArtifacts(octokit, repository, name) { } function getPrNumber() { - if (github.context.eventName === 'pull_request') { + if (github.context.eventName === "pull_request") { return github.context.payload.pull_request.number; } return undefined; @@ -39,10 +39,23 @@ function getPrNumber() { async function run() { try { - const token = core.getInput('github-token'); - const repository = core.getInput('repository'); - const name = core.getInput('name'); - const reSign = core.getInput('re-sign'); + const token = core.getInput("github_token") || process.env.GITHUB_TOKEN; + + if (!token) { + throw new Error("GitHub token is required"); + } + + const repository = core.getInput("repository"); + if (!repository) { + throw new Error("Repository is required"); + } + + const name = core.getInput("name"); + if (!name) { + throw new Error("Artifact name is required"); + } + + const reSign = core.getInput("re_sign"); const prNumber = getPrNumber(); const octokit = github.getOctokit(token); @@ -61,20 +74,20 @@ async function run() { for (const artifact of artifacts) { console.log( `- ID: ${artifact.id}, Name: ${artifact.name}, Size: ${formatSize( - artifact.size_in_bytes, - )}, Expires at: ${artifact.expires_at}`, + artifact.size_in_bytes + )}, Expires at: ${artifact.expires_at}` ); } - const firstArtifact = artifacts.find(artifact => !artifact.expired); + const firstArtifact = artifacts.find((artifact) => !artifact.expired); console.log(`First artifact: ${JSON.stringify(firstArtifact, null, 2)}`); const url = formatDownloadUrl( repository, firstArtifact.workflow_run.id, - firstArtifact.id, + firstArtifact.id ); - console.log('Stable download URL:', url); + console.log("Stable download URL:", url); let artifactName = name; // There are artifacts from PR but the base artifact is gone, recreate with the original name @@ -84,12 +97,12 @@ async function run() { } else if (prNumber && reSign) { artifactName = `${name}-${prNumber}`; } - core.setOutput('artifact-name', artifactName); - core.setOutput('artifact-id', firstArtifact.id); - core.setOutput('artifact-url', url); + core.setOutput("artifact-name", artifactName); + core.setOutput("artifact-id", firstArtifact.id); + core.setOutput("artifact-url", url); core.setOutput( - 'artifact-ids', - artifactsByPrNumber.map(artifact => artifact.id).join(' '), + "artifact-ids", + artifactsByPrNumber.map((artifact) => artifact.id).join(" ") ); } catch (error) { core.setFailed(`Action failed with error: ${error.message}`); diff --git a/.github/actions/rnef-native-fingerprint/action.yml b/.github/actions/rnef-native-fingerprint/action.yml index fedd910..79e0d58 100644 --- a/.github/actions/rnef-native-fingerprint/action.yml +++ b/.github/actions/rnef-native-fingerprint/action.yml @@ -11,12 +11,18 @@ inputs: outputs: hash: description: 'The fingerprint hash' + value: ${{ steps.fingerprint.outputs.hash }} runs: - using: 'composite' + using: "composite" steps: - name: Install dependencies run: npm install shell: bash + working-directory: ${{ github.action_path }} - name: Run fingerprint - run: node index.mjs + id: fingerprint + env: + INPUT_PLATFORM: ${{ inputs.platform }} + INPUT_WORKING_DIRECTORY: ${{ inputs.working-directory }} + run: node ${{ github.action_path }}/index.mjs shell: bash diff --git a/.github/actions/rnef-native-fingerprint/package.json b/.github/actions/rnef-native-fingerprint/package.json index 54ec520..77e5b0d 100644 --- a/.github/actions/rnef-native-fingerprint/package.json +++ b/.github/actions/rnef-native-fingerprint/package.json @@ -4,6 +4,7 @@ "description": "Generate native fingerprint for RNEF builds", "main": "index.mjs", "dependencies": { + "@rnef/config": "^0.4.1", "@actions/core": "^1.11.1" } } \ No newline at end of file diff --git a/.github/actions/rnef-post-build/action.yml b/.github/actions/rnef-post-build/action.yml index cefb167..bd466e7 100644 --- a/.github/actions/rnef-post-build/action.yml +++ b/.github/actions/rnef-post-build/action.yml @@ -13,11 +13,17 @@ inputs: required: false default: ${{ github.token }} runs: - using: 'composite' + using: "composite" steps: - name: Install dependencies run: npm install shell: bash - - name: Run post build - run: node index.js + working-directory: ${{ github.action_path }} + - name: Post build + id: post-build + env: + INPUT_ARTIFACT_URL: ${{ inputs.artifact-url }} + INPUT_TITLE: ${{ inputs.title }} + INPUT_GITHUB_TOKEN: ${{ inputs.github-token }} + run: node ${{ github.action_path }}/index.mjs shell: bash diff --git a/.github/actions/rnef-post-build/index.js b/.github/actions/rnef-post-build/index.mjs similarity index 68% rename from .github/actions/rnef-post-build/index.js rename to .github/actions/rnef-post-build/index.mjs index e268efe..b46067b 100644 --- a/.github/actions/rnef-post-build/index.js +++ b/.github/actions/rnef-post-build/index.mjs @@ -1,10 +1,21 @@ -const core = require('@actions/core'); -const github = require('@actions/github'); +import * as core from '@actions/core'; +import * as github from '@actions/github'; async function run() { - const token = core.getInput('github-token'); - const titleInput = core.getInput('title'); - const artifactUrl = core.getInput('artifact-url'); + const token = core.getInput("github_token") || process.env.GITHUB_TOKEN; + if (!token) { + throw new Error("GitHub token is required"); + } + + const titleInput = core.getInput("title"); + if (!titleInput) { + throw new Error("Title is required"); + } + + const artifactUrl = core.getInput("artifact_url"); + if (!artifactUrl) { + throw new Error("Artifact URL is required"); + } const title = `## ${titleInput}`; const body = `🔗 [Download link](${artifactUrl}).\n\n diff --git a/action.yml b/action.yml index 2ec0b6d..785292d 100644 --- a/action.yml +++ b/action.yml @@ -102,7 +102,7 @@ runs: - name: Native Fingerprint id: fingerprint - uses: callstackincubator/ios/.github/actions/rnef-native-fingerprint@v1 + uses: callstackincubator/ios/.github/actions/rnef-native-fingerprint@fix/composite with: platform: ios working-directory: ${{ inputs.working-directory }} @@ -114,10 +114,11 @@ runs: - name: Find artifact URL id: find-artifact - uses: callstackincubator/ios/.github/actions/find-artifact@v1 + uses: callstackincubator/ios/.github/actions/find-artifact@fix/composite with: name: ${{ env.ARTIFACT_NAME }} re-sign: ${{ inputs.re-sign }} + github-token: ${{ inputs.github-token }} - name: Set Provisioning Profile Path run: | @@ -256,7 +257,8 @@ runs: - name: Post Build if: ${{ github.event_name == 'pull_request' && inputs.comment-bot == 'true' }} - uses: callstackincubator/ios/.github/actions/rnef-post-build@v1 + uses: callstackincubator/ios/.github/actions/rnef-post-build@fix/composite with: title: iOS ${{ inputs.configuration }} ${{ inputs.destination == 'simulator' && 'APP for simulators' || 'IPA for physical devices' }} artifact-url: ${{ steps.upload-artifact.outputs.artifact-url || steps.find-artifact.outputs.artifact-url }} + github-token: ${{ inputs.github-token }} \ No newline at end of file diff --git a/package.json b/package.json index 65f562c..ea20439 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "action-ios", "version": "1.0.0", - "description": "GitHub Action for building iOS applications using RNEF (React Native EAS Fastlane)", + "description": "GitHub Action for building iOS applications using RNEF (React Native Enterprise Framework)", "main": "index.js", "author": "", "license": "MIT", From 70edf73967797d8e2f4370214e9c292663e2c3bd Mon Sep 17 00:00:00 2001 From: szymonrybczak Date: Tue, 18 Mar 2025 19:05:56 +0100 Subject: [PATCH 3/6] chore: lint --- .github/actions/find-artifact/action.yml | 14 ++++++------- .github/actions/find-artifact/package.json | 2 +- .../rnef-native-fingerprint/action.yml | 2 +- .../actions/rnef-native-fingerprint/index.mjs | 20 +++++++++--------- .../rnef-native-fingerprint/package.json | 2 +- .github/actions/rnef-post-build/action.yml | 2 +- .github/actions/rnef-post-build/index.mjs | 16 +++++++------- .github/actions/rnef-post-build/package.json | 2 +- .github/workflows/main.yml | 21 ------------------- README.md | 1 + action.yml | 2 +- 11 files changed, 32 insertions(+), 52 deletions(-) delete mode 100644 .github/workflows/main.yml diff --git a/.github/actions/find-artifact/action.yml b/.github/actions/find-artifact/action.yml index 1975e0a..178a7cb 100644 --- a/.github/actions/find-artifact/action.yml +++ b/.github/actions/find-artifact/action.yml @@ -1,8 +1,8 @@ -name: "Find Artifact" -description: "Find the latest artifact" +name: 'Find Artifact' +description: 'Find the latest artifact' inputs: name: - description: "Artifact name" + description: 'Artifact name' required: false re-sign: description: Re-sign the app bundle with new JS bundle @@ -19,16 +19,16 @@ inputs: default: ${{ github.repository }} outputs: artifact-id: - description: "The ID of the artifact" + description: 'The ID of the artifact' value: ${{ steps.find-artifact.outputs.artifact-id }} artifact-url: - description: "The URL of the artifact" + description: 'The URL of the artifact' value: ${{ steps.find-artifact.outputs.artifact-url }} artifact-ids: - description: "All IDs of the artifacts matching the name" + description: 'All IDs of the artifacts matching the name' value: ${{ steps.find-artifact.outputs.artifact-ids }} runs: - using: "composite" + using: 'composite' steps: - name: Install dependencies run: npm install diff --git a/.github/actions/find-artifact/package.json b/.github/actions/find-artifact/package.json index 1818861..d1e86da 100644 --- a/.github/actions/find-artifact/package.json +++ b/.github/actions/find-artifact/package.json @@ -7,4 +7,4 @@ "@actions/core": "^1.11.1", "@actions/github": "^6.0.0" } -} \ No newline at end of file +} diff --git a/.github/actions/rnef-native-fingerprint/action.yml b/.github/actions/rnef-native-fingerprint/action.yml index 79e0d58..aec7103 100644 --- a/.github/actions/rnef-native-fingerprint/action.yml +++ b/.github/actions/rnef-native-fingerprint/action.yml @@ -13,7 +13,7 @@ outputs: description: 'The fingerprint hash' value: ${{ steps.fingerprint.outputs.hash }} runs: - using: "composite" + using: 'composite' steps: - name: Install dependencies run: npm install diff --git a/.github/actions/rnef-native-fingerprint/index.mjs b/.github/actions/rnef-native-fingerprint/index.mjs index 486e4ef..40e9ac0 100644 --- a/.github/actions/rnef-native-fingerprint/index.mjs +++ b/.github/actions/rnef-native-fingerprint/index.mjs @@ -1,13 +1,13 @@ -import path from 'node:path'; -import core from '@actions/core'; -import {getConfig} from '@rnef/config'; -import {nativeFingerprint} from '@rnef/tools'; +import path from "node:path"; +import core from "@actions/core"; +import { getConfig } from "@rnef/config"; +import { nativeFingerprint } from "@rnef/tools"; -const ALLOWED_PLATFORMS = ['android', 'ios']; +const ALLOWED_PLATFORMS = ["android", "ios"]; async function run() { - const platform = core.getInput('platform'); - const workingDirectory = core.getInput('working-directory'); + const platform = core.getInput("platform"); + const workingDirectory = core.getInput("working-directory"); if (!ALLOWED_PLATFORMS.includes(platform)) { throw new Error(`Invalid platform: ${platform}`); } @@ -22,10 +22,10 @@ async function run() { ...fingerprintOptions, }); - console.log('Hash:', fingerprint.hash); - console.log('Sources:', fingerprint.sources); + console.log("Hash:", fingerprint.hash); + console.log("Sources:", fingerprint.sources); - core.setOutput('hash', fingerprint.hash); + core.setOutput("hash", fingerprint.hash); } await run(); diff --git a/.github/actions/rnef-native-fingerprint/package.json b/.github/actions/rnef-native-fingerprint/package.json index 77e5b0d..7946ad9 100644 --- a/.github/actions/rnef-native-fingerprint/package.json +++ b/.github/actions/rnef-native-fingerprint/package.json @@ -7,4 +7,4 @@ "@rnef/config": "^0.4.1", "@actions/core": "^1.11.1" } -} \ No newline at end of file +} diff --git a/.github/actions/rnef-post-build/action.yml b/.github/actions/rnef-post-build/action.yml index bd466e7..674ee64 100644 --- a/.github/actions/rnef-post-build/action.yml +++ b/.github/actions/rnef-post-build/action.yml @@ -13,7 +13,7 @@ inputs: required: false default: ${{ github.token }} runs: - using: "composite" + using: 'composite' steps: - name: Install dependencies run: npm install diff --git a/.github/actions/rnef-post-build/index.mjs b/.github/actions/rnef-post-build/index.mjs index b46067b..8ee83fa 100644 --- a/.github/actions/rnef-post-build/index.mjs +++ b/.github/actions/rnef-post-build/index.mjs @@ -1,5 +1,5 @@ -import * as core from '@actions/core'; -import * as github from '@actions/github'; +import core from "@actions/core"; +import github from "@actions/github"; async function run() { const token = core.getInput("github_token") || process.env.GITHUB_TOKEN; @@ -23,15 +23,15 @@ Note: if the download link expires, please re-run the workflow to generate a new *Generated at ${new Date().toISOString()} UTC*\n`; const octokit = github.getOctokit(token); - const {data: comments} = await octokit.rest.issues.listComments({ + const { data: comments } = await octokit.rest.issues.listComments({ ...github.context.repo, issue_number: github.context.issue.number, }); const botComment = comments.find( - comment => - comment.user.login === 'github-actions[bot]' && - comment.body.includes(title), + (comment) => + comment.user.login === "github-actions[bot]" && + comment.body.includes(title) ); if (botComment) { @@ -40,14 +40,14 @@ Note: if the download link expires, please re-run the workflow to generate a new comment_id: botComment.id, body: `${title}\n\n${body}`, }); - console.log('Updated comment'); + console.log("Updated comment"); } else { await octokit.rest.issues.createComment({ ...github.context.repo, issue_number: github.context.issue.number, body: `${title}\n\n${body}`, }); - console.log('Created comment'); + console.log("Created comment"); } } diff --git a/.github/actions/rnef-post-build/package.json b/.github/actions/rnef-post-build/package.json index b77f415..994d93f 100644 --- a/.github/actions/rnef-post-build/package.json +++ b/.github/actions/rnef-post-build/package.json @@ -7,4 +7,4 @@ "@actions/core": "^1.11.1", "@actions/github": "^6.0.0" } -} \ No newline at end of file +} diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml deleted file mode 100644 index 9e448df..0000000 --- a/.github/workflows/main.yml +++ /dev/null @@ -1,21 +0,0 @@ -name: Test - -on: - push: - branches: [main] - pull_request: - branches: ['**'] - -jobs: - build-simulator: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - - name: Setup Node - uses: actions/setup-node@v4 - with: - cache: 'npm' - - - name: Install dependencies - run: npm install diff --git a/README.md b/README.md index eda71dd..00f9cd5 100644 --- a/README.md +++ b/README.md @@ -33,6 +33,7 @@ jobs: destination: 'simulator' # or 'device' scheme: 'YourScheme' configuration: 'Debug' + github-token: ${{ secrets.GITHUB_TOKEN }} # For device builds, add these: # certificate-base64: ${{ secrets.CERTIFICATE_BASE64 }} # certificate-password: ${{ secrets.CERTIFICATE_PASSWORD }} diff --git a/action.yml b/action.yml index 785292d..88b9f85 100644 --- a/action.yml +++ b/action.yml @@ -261,4 +261,4 @@ runs: with: title: iOS ${{ inputs.configuration }} ${{ inputs.destination == 'simulator' && 'APP for simulators' || 'IPA for physical devices' }} artifact-url: ${{ steps.upload-artifact.outputs.artifact-url || steps.find-artifact.outputs.artifact-url }} - github-token: ${{ inputs.github-token }} \ No newline at end of file + github-token: ${{ inputs.github-token }} From a9d59d3a152d934c73d1653084aa65eca2323120 Mon Sep 17 00:00:00 2001 From: szymonrybczak Date: Tue, 18 Mar 2025 19:08:29 +0100 Subject: [PATCH 4/6] github-token --- .github/actions/rnef-post-build/action.yml | 3 +-- action.yml | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/actions/rnef-post-build/action.yml b/.github/actions/rnef-post-build/action.yml index 674ee64..f01bf35 100644 --- a/.github/actions/rnef-post-build/action.yml +++ b/.github/actions/rnef-post-build/action.yml @@ -10,8 +10,7 @@ inputs: required: true github-token: description: A GitHub Personal Access Token with write access to the project - required: false - default: ${{ github.token }} + required: true runs: using: 'composite' steps: diff --git a/action.yml b/action.yml index 88b9f85..9f4bdfa 100644 --- a/action.yml +++ b/action.yml @@ -8,8 +8,7 @@ branding: inputs: github-token: description: GitHub Token - required: false - default: ${{ github.token }} + required: true working-directory: description: 'Working directory for the build command' required: false From 8d025fd85bbd4981fc295573f6c169b48fd75a08 Mon Sep 17 00:00:00 2001 From: szymonrybczak Date: Tue, 18 Mar 2025 19:19:13 +0100 Subject: [PATCH 5/6] fix docs --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 00f9cd5..364939d 100644 --- a/README.md +++ b/README.md @@ -46,7 +46,7 @@ jobs: | Input | Description | Required | Default | | ----------------------------- | ------------------------------------------ | -------- | --------------------- | -| `github-token` | GitHub Token | No | `${{ github.token }}` | +| `github-token` | GitHub Token | Yes | - | | `working-directory` | Working directory for the build command | No | `.` | | `destination` | Build destination: "simulator" or "device" | Yes | `simulator` | | `scheme` | Xcode scheme | Yes | - | From 9a4e04a3e98985f97d4dfc3a1b0acd205494c3a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Wed, 26 Mar 2025 11:48:46 +0100 Subject: [PATCH 6/6] switch branch to v1 tag --- action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/action.yml b/action.yml index 9f4bdfa..c030c83 100644 --- a/action.yml +++ b/action.yml @@ -101,7 +101,7 @@ runs: - name: Native Fingerprint id: fingerprint - uses: callstackincubator/ios/.github/actions/rnef-native-fingerprint@fix/composite + uses: callstackincubator/ios/.github/actions/rnef-native-fingerprint@v1 with: platform: ios working-directory: ${{ inputs.working-directory }} @@ -113,7 +113,7 @@ runs: - name: Find artifact URL id: find-artifact - uses: callstackincubator/ios/.github/actions/find-artifact@fix/composite + uses: callstackincubator/ios/.github/actions/find-artifact@v1 with: name: ${{ env.ARTIFACT_NAME }} re-sign: ${{ inputs.re-sign }} @@ -256,7 +256,7 @@ runs: - name: Post Build if: ${{ github.event_name == 'pull_request' && inputs.comment-bot == 'true' }} - uses: callstackincubator/ios/.github/actions/rnef-post-build@fix/composite + uses: callstackincubator/ios/.github/actions/rnef-post-build@v1 with: title: iOS ${{ inputs.configuration }} ${{ inputs.destination == 'simulator' && 'APP for simulators' || 'IPA for physical devices' }} artifact-url: ${{ steps.upload-artifact.outputs.artifact-url || steps.find-artifact.outputs.artifact-url }}