enumerator: fill in 'product' and 'manufacturer' on linux

[bearsh]

handling of values of 'product' and 'manufacturer' is commented on linux, see

go-serial/enumerator/usb_linux.go

Lines 75 to 94 in e381f2c

	serial, err := readLine(filepath.Join(usbDevicePath, "serial"))
	if err != nil {
	return err
	}
	//manufacturer, err := readLine(filepath.Join(usbDevicePath, "manufacturer"))
	//if err != nil {
	// return err
	//}
	//product, err := readLine(filepath.Join(usbDevicePath, "product"))
	//if err != nil {
	// return err
	//}
	details.IsUSB = true
	details.VID = vid
	details.PID = pid
	details.SerialNumber = serial
	//details.Manufacturer = manufacturer
	//details.Product = product
	return nil

is there a specific reason for this? can this be enabled?

[mangelajo]

I was going to ask for the same thing, I see there was support in darwin too:

go-serial/enumerator/usb_darwin.go

Line 73 in e381f2c

//product, _ := usbDevice.GetStringProperty("USB Product Name")

I'd find this useful

even if we can get the version (bcdDevice)

If we had those things I could switch from my implementation for device lookup here https://github.com/redhat-et/jumpstarter/blob/main/pkg/drivers/jumpstarter-board/udev.go into using go-serial completely.

[randomouscrap98]

I'm sorry to resurface an old issue, but I'm also interested: why aren't these reported? If it's that some devices error out, I'd rather have the product set on the ones that work rather than have them ALL blank (if possible)

Edit: ah, I forgot about libudev. Is this done to remove dependencies on cgo?