Skip to content

Questions about NLL computation in the "maze2d" branch #9

@Jang-seunghwan

Description

@Jang-seunghwan

While attempting to compute the negative log-likelihood (NLL) for the Maze2D task,
I ran into a few points that I’m hoping you can clarify:

  1. L_0 term in vb_terms_bpd
    The current implementation comments out the L_0 calculation
  • Is it correct to simply uncomment this block when we want to include L_0 in the NLL?
  • I assume the L_T term was omitted in function because its contribution is ~0; is it right?
  1. Potential mismatch in the ELBO call
    In diffuser/guides/policies.py the ELBO is computed with
    elbo_i = self.diffusion_model._vb_terms_bpd( diffuser_state, conditions, diffusion[:, step, :, :], timesteps )
    Here, diffusion[:, step, :, :] seems to be an x_t sampled from an independent diffusion trajectory,
    so it may not align with diffuser_state. Is this intentional, or should both tensors come from the same trajectory?

  2. Division NLL by 255
    sum_elbo = sum_elbo.detach().cpu().numpy()[0] / 255 # ave
    It makes sense for image data, where pixel values lie in 0…255. But the Maze2D trajectories are already scaled to the range −1,1,
    so this extra division seems unnecessary.
    Could you share the reasoning behind this 255-scaling step?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions