-
Notifications
You must be signed in to change notification settings - Fork 10
Description
While attempting to compute the negative log-likelihood (NLL) for the Maze2D task,
I ran into a few points that I’m hoping you can clarify:
- L_0 term in
vb_terms_bpd
The current implementation comments out the L_0 calculation
- Is it correct to simply uncomment this block when we want to include L_0 in the NLL?
- I assume the L_T term was omitted in function because its contribution is ~0; is it right?
-
Potential mismatch in the ELBO call
In diffuser/guides/policies.py the ELBO is computed with
elbo_i = self.diffusion_model._vb_terms_bpd( diffuser_state, conditions, diffusion[:, step, :, :], timesteps )
Here,diffusion[:, step, :, :]seems to be an x_t sampled from an independent diffusion trajectory,
so it may not align withdiffuser_state. Is this intentional, or should both tensors come from the same trajectory? -
Division NLL by 255
sum_elbo = sum_elbo.detach().cpu().numpy()[0] / 255 # ave
It makes sense for image data, where pixel values lie in 0…255. But the Maze2D trajectories are already scaled to the range −1,1,
so this extra division seems unnecessary.
Could you share the reasoning behind this 255-scaling step?