forked from dimitri/pgloader
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't workingcomponent: schemaDDL generation, schema discovery, indexesDDL generation, schema discovery, indexessource: mssqlMS SQL Server source migrationsMS SQL Server source migrations
Description
Upstream PR
Summary
COLUMNPROPERTY(object_id(c.TABLE_NAME), ...) was scoped to default schema only. Fix qualifies with schema: COLUMNPROPERTY(OBJECT_ID(c.TABLE_SCHEMA + '.' + c.TABLE_NAME), ...).
Files
src/sources/mssql/sql/list-all-columns.sql
Notes
- Low risk, 1-line change
- Fixes upstream Mssql: IDENTITY columns not detected in tables outside the default schema. dimitri/pgloader#1586
- Overlaps with PR Handle non-standard schemas when looking up identity column dimitri/pgloader#1436 (same fix, different SQL syntax) — this one is preferred
- Priority: High
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcomponent: schemaDDL generation, schema discovery, indexesDDL generation, schema discovery, indexessource: mssqlMS SQL Server source migrationsMS SQL Server source migrations