feat(builtin): disassemble can show a file bytecode

Author: SuperFola

CHANGELOG.md

@@ -12,6 +12,7 @@
 
 ### Changed
 - quotes are added around strings in type errors
+- `disassemble` can show a file bytecode
 
 ### Removed
 

src/arkreactor/Builtins/Bytecode.cpp

@@ -3,6 +3,7 @@
 #include <Ark/Compiler/BytecodeReader.hpp>
 #include <Ark/VM/VM.hpp>
 
+#include <Ark/Utils/Files.hpp>
 #include <Ark/VM/DefaultValues.hpp>
 #include <Ark/TypeChecker.hpp>
 
@@ -21,15 +22,28 @@ namespace Ark::internal::Builtins::Bytecode
     // cppcheck-suppress constParameterReference
     Value disassemble(std::vector<Value>& n, VM* vm)
     {
-        if (!types::check(n, ValueType::PageAddr))
+        if (!types::check(n, ValueType::PageAddr) && !types::check(n, ValueType::String))
             throw types::TypeCheckingError(
                 "disassemble",
-                { { types::Contract { { types::Typedef("f", ValueType::PageAddr) } } } },
+                { { types::Contract { { types::Typedef("f", ValueType::PageAddr) } },
+                    types::Contract { { types::Typedef("filename", ValueType::String) } } } },
                 n);
 
         BytecodeReader bcr;
-        bcr.feed(vm->bytecode());
-        bcr.display(BytecodeSegment::Code, std::nullopt, std::nullopt, n[0].pageAddr());
+        if (n[0].valueType() == ValueType::PageAddr)
+        {
+            bcr.feed(vm->bytecode());
+            bcr.display(BytecodeSegment::Code, std::nullopt, std::nullopt, n[0].pageAddr());
+        }
+        else if (n[0].valueType() == ValueType::String)
+        {
+            const std::string filename = n[0].string();
+            if (!Utils::fileExists(filename))
+                throw Error(fmt::format("`disassemble': can not read file {}", filename));
+
+            bcr.feed(filename);
+            bcr.display();
+        }
 
         return Nil;
     }

tests/unittests/resources/DiagnosticsSuite/typeChecking/disassemble_not_existing_file.ark

@@ -0,0 +1 @@
+(disassemble "this_file_should_not_exist.1234")

tests/unittests/resources/DiagnosticsSuite/typeChecking/disassemble_not_existing_file.expected

@@ -0,0 +1,6 @@
+`disassemble': can not read file this_file_should_not_exist.1234
+
+In file tests/unittests/resources/DiagnosticsSuite/typeChecking/disassemble_not_existing_file.ark:1
+    1 | (disassemble "this_file_should_not_exist.1234")
+      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+    2 |

tests/unittests/resources/DiagnosticsSuite/typeChecking/disassemble_num.expected

@@ -6,7 +6,13 @@ Signature
 Arguments
   → `f' (expected Function), got 1 (Number)
 
+Alternative 2:
+Signature
+  ↳ (disassemble filename)
+Arguments
+  → `filename' (expected String), got 1 (Number)
+
 In file tests/unittests/resources/DiagnosticsSuite/typeChecking/disassemble_num.ark:1
     1 | (disassemble 1)
       | ^~~~~~~~~~~~~~
-    2 |
+    2 |

tests/unittests/resources/LangSuite/builtins-tests.ark

@@ -24,4 +24,5 @@
         (test:expect (and (<= r 2147483647) (>= r -2147483648))) })
 
     (test:case "disassemble" {
-      (disassemble foo) }) })
+      (disassemble foo)
+      (disassemble "tests/unittests/resources/DiagnosticsSuite/runtime/__arkscript__/assert.arkc") }) })